chore: updating and removing tests

[nnshah1]

Overview:

Removing outdated tests.

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

• closes GitHub issue: #xxx

Summary by CodeRabbit

• Documentation

  • Updated test directory documentation to reflect recent structural changes and simplify descriptions.
  • Removed detailed documentation and results for fault tolerance testing.

• Tests

  • Removed all fault tolerance end-to-end tests, utilities, scenarios, configuration files, and metrics collection scripts.
  • Deleted the test suite for Dynamo Serve deployments.
  • Removed the DeploymentGraph test utility class.

• Chores

  • Cleaned up obsolete test files and related utilities.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

Walkthrough

This change removes the entire fault tolerance test suite, its configuration files, supporting utilities, and associated documentation from the codebase. It also deletes the end-to-end serve test and the DeploymentGraph dataclass. The documentation for the test directory is updated to reflect these removals and the addition of a utils directory.

Changes

File(s)	Change Summary
tests/fault_tolerance/README.md, tests/fault_tolerance/parse_results.py, tests/fault_tolerance/scenarios.py, tests/fault_tolerance/test_runner.py, tests/fault_tolerance/conftest.py	Deleted all test suite code, documentation, scenarios, runner, and pytest config for fault tolerance tests.
tests/fault_tolerance/utils/circus_controller.py, tests/fault_tolerance/utils/metrics.py	Deleted utility modules for process control and runtime metrics used in fault tolerance testing.
tests/fault_tolerance/configs/*.yaml	Deleted all YAML configuration files for fault tolerance test topologies and scenarios.
tests/serve/test_dynamo_serve.py	Deleted end-to-end serve test, including process management and deployment graph testing.
tests/utils/deployment_graph.py	Removed the DeploymentGraph dataclass and related imports.
tests/README.md	Updated documentation: removed references to deleted directories and added description for utils.

Sequence Diagram(s)

No sequence diagram generated as the change is a comprehensive removal of test infrastructure and documentation, not a modification of control flow or feature logic.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~40 minutes

Possibly related PRs

• test: fault tolerance tests #1444: Adds the fault tolerance test suite and its components, which are now being removed in this PR—directly related as inverse changes.
• fix: Update trtllm tests to use new scripts instead of dynamo serve #1979: Modifies the same tests/serve/test_dynamo_serve.py file that is fully deleted here; both PRs affect the same test infrastructure.
• test: basic end to end #1339: Replaces the removed fault tolerance test infrastructure with a new, simpler end-to-end test framework—related as both alter the testing approach.

Poem

A rabbit hopped through tests galore,
But now the fault suite is no more.
Configs and runners, all swept away,
To make the codebase light today.
With docs refreshed and utils in view,
The garden’s pruned for something new!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/README.md (1)

14-14: Fix typo in directory comment

accross → across.

-├── utils               # Common utils accross tests
+├── utils               # Common utils across tests

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4498a77 and 04fa9b5.

📒 Files selected for processing (22)

• tests/README.md (1 hunks)
• tests/fault_tolerance/README.md (0 hunks)
• tests/fault_tolerance/configs/agg_tp_1_dp_1.yaml (0 hunks)
• tests/fault_tolerance/configs/agg_tp_1_dp_4.yaml (0 hunks)
• tests/fault_tolerance/configs/agg_tp_1_dp_8.yaml (0 hunks)
• tests/fault_tolerance/configs/agg_tp_2_dp_1.yaml (0 hunks)
• tests/fault_tolerance/configs/agg_tp_2_dp_2.yaml (0 hunks)
• tests/fault_tolerance/configs/agg_tp_2_dp_4.yaml (0 hunks)
• tests/fault_tolerance/configs/disagg_p_tp_1_dp_1_d_tp_1_dp_1.yaml (0 hunks)
• tests/fault_tolerance/configs/disagg_p_tp_1_dp_1_d_tp_2_dp_1.yaml (0 hunks)
• tests/fault_tolerance/configs/disagg_p_tp_1_dp_2_d_tp_2_dp_1.yaml (0 hunks)
• tests/fault_tolerance/configs/disagg_p_tp_1_dp_4_d_tp_4_dp_1.yaml (0 hunks)
• tests/fault_tolerance/configs/disagg_p_tp_2_dp_1_d_tp_4_dp_1.yaml (0 hunks)
• tests/fault_tolerance/configs/disagg_p_tp_2_dp_2_d_tp_4_dp_1.yaml (0 hunks)
• tests/fault_tolerance/conftest.py (0 hunks)
• tests/fault_tolerance/parse_results.py (0 hunks)
• tests/fault_tolerance/scenarios.py (0 hunks)
• tests/fault_tolerance/test_runner.py (0 hunks)
• tests/fault_tolerance/utils/circus_controller.py (0 hunks)
• tests/fault_tolerance/utils/metrics.py (0 hunks)
• tests/serve/test_dynamo_serve.py (0 hunks)
• tests/utils/deployment_graph.py (1 hunks)

💤 Files with no reviewable changes (20)

• tests/fault_tolerance/configs/agg_tp_2_dp_4.yaml
• tests/fault_tolerance/configs/disagg_p_tp_2_dp_1_d_tp_4_dp_1.yaml
• tests/fault_tolerance/configs/agg_tp_1_dp_8.yaml
• tests/fault_tolerance/configs/agg_tp_2_dp_2.yaml
• tests/fault_tolerance/configs/disagg_p_tp_1_dp_1_d_tp_1_dp_1.yaml
• tests/fault_tolerance/configs/disagg_p_tp_1_dp_4_d_tp_4_dp_1.yaml
• tests/fault_tolerance/configs/disagg_p_tp_1_dp_2_d_tp_2_dp_1.yaml
• tests/fault_tolerance/configs/agg_tp_1_dp_1.yaml
• tests/fault_tolerance/configs/disagg_p_tp_1_dp_1_d_tp_2_dp_1.yaml
• tests/fault_tolerance/configs/disagg_p_tp_2_dp_2_d_tp_4_dp_1.yaml
• tests/fault_tolerance/configs/agg_tp_1_dp_4.yaml
• tests/fault_tolerance/configs/agg_tp_2_dp_1.yaml
• tests/fault_tolerance/utils/metrics.py
• tests/fault_tolerance/scenarios.py
• tests/serve/test_dynamo_serve.py
• tests/fault_tolerance/utils/circus_controller.py
• tests/fault_tolerance/test_runner.py
• tests/fault_tolerance/conftest.py
• tests/fault_tolerance/README.md
• tests/fault_tolerance/parse_results.py

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: nnshah1
PR: ai-dynamo/dynamo#1444
File: tests/fault_tolerance/scenarios.py:57-57
Timestamp: 2025-07-01T15:39:56.789Z
Learning: The fault tolerance tests in tests/fault_tolerance/ are designed to run only in the mounted container environment, so hardcoded absolute paths with `/workspace/` prefix are intentional and should not be changed to relative paths.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build and Test - vllm

🔇 Additional comments (1)

tests/utils/deployment_graph.py (1)

16-17: Import cleanup improves clarity

Removing the unused field and Callable symbols tightens the file’s surface area and avoids misleading readers about non-existent functionality.