-
Notifications
You must be signed in to change notification settings - Fork 690
chore: update vLLM to 0.10.0 #2114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/ok to test 7305cc9 |
WalkthroughThe changes update the default vLLM version reference from a specific commit hash to the version tag "v0.10.0" in both the Dockerfile and the installation script. No other logic, structure, or exported entities were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
container/deps/vllm/install_vllm.sh (1)
80-83: Help-text default is now stale.
The usage string still advertises the old commit hash (059d4cd). Update it to the same default you set in the variable so users are not misled.- --vllm-ref REF Git reference to checkout (default: 059d4cd) + --vllm-ref REF Git reference to checkout (default: v0.10.10)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
container/Dockerfile.vllm(1 hunks)container/deps/vllm/install_vllm.sh(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Mirror Repository to GitLab
- GitHub Check: Build and Test - vllm
3886971 to
9f98f80
Compare
|
FYI @ptarasiewiczNV I rebased this, so if you need to pull it make sure to overwrite your local. |
Overview:
Use newest vLLM release: https://github.com/vllm-project/vllm/releases/tag/v0.10.0
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit