Skip to content

Conversation

@ishandhanani
Copy link
Contributor

@ishandhanani ishandhanani commented Jul 16, 2025

With the new UX, we do not need this SDK (after the multi modal examples are wrapped up)

Summary by CodeRabbit

  • Chores
    • Removed the SDK's CLI, core libraries, decorators, resource management, configuration, and test files.
    • Deleted documentation, example pipelines, and configuration files.
    • Eliminated all end-to-end and unit tests related to the SDK.
    • Removed deployment scripts and environment setup utilities.

End-users will no longer have access to the Dynamo SDK's CLI tools, service configuration, resource management, or example/test assets.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 16, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 16, 2025

Walkthrough

This change removes the entire Dynamo SDK Python package, including all CLI commands, service abstractions, core protocols, resource management, configuration utilities, and all related documentation, tests, and configuration files. The deletion encompasses every core module, decorator, utility, and test in the SDK's deployment directory, as well as the CODEOWNERS file.

Changes

Files/Groups Change Summary
CODEOWNERS Deleted repository ownership configuration file.
deploy/sdk/README.md, deploy/sdk/docs/cli/README.md, deploy/sdk/docs/sdk/README.md Deleted SDK and CLI documentation files.
deploy/sdk/src/dynamo/sdk/init.py, deploy/sdk/src/dynamo/sdk/core/init.py, ... Deleted all SDK package initializers and core modules, removing all public API exports and licensing headers.
deploy/sdk/src/dynamo/sdk/cli/* Deleted all CLI modules: allocator, circus, cli, env, run, run_executable, serve, serve_dynamo, serving, utils.
deploy/sdk/src/dynamo/sdk/core/decorators/endpoint.py Deleted endpoint decorator and client system for distributed runtime.
deploy/sdk/src/dynamo/sdk/core/lib.py, deploy/sdk/src/dynamo/sdk/core/protocol/* Deleted service management, protocol, and interface abstractions.
deploy/sdk/src/dynamo/sdk/core/runner/* Deleted runner modules: target enum, service mixin, local deployment, health checks.
deploy/sdk/src/dynamo/sdk/lib/* Deleted all SDK library files: config, decorators, exceptions, image, loader, resource, utils.
deploy/sdk/src/dynamo/sdk/tests/* Deleted all SDK test files, including configs, pipeline example, unit tests, and e2e tests.
deploy/sdk/tests/test_deployment.sh Deleted Bash deployment test script.

Sequence Diagram(s)

No sequence diagram generated, as the change is a wholesale removal of code and does not introduce or modify any control flow.

Possibly related PRs

Poem

A rabbit hopped through fields of code,
And swept away the SDK load.
No CLI to serve or test to run,
The modules vanished, one by one.
In empty burrows, silence grows—
The garden’s cleared, as the changelog shows!
🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 182d3b5 and 400cae1.

📒 Files selected for processing (42)
  • CODEOWNERS (0 hunks)
  • deploy/sdk/README.md (0 hunks)
  • deploy/sdk/docs/cli/README.md (0 hunks)
  • deploy/sdk/docs/sdk/README.md (0 hunks)
  • deploy/sdk/src/dynamo/sdk/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/Dockerfile.template (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/allocator.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/circus.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/cli.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/env.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/run.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/run_executable.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/serve.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/serve_dynamo.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/serving.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/cli/utils.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/decorators/endpoint.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/lib.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/protocol/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/protocol/deployment.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/protocol/interface.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/runner/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/runner/common.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/runner/dynamo.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/runner/health.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/config.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/decorators.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/exceptions.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/image.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/loader.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/resource.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/lib/utils.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/config.yaml (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/pipeline.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/test_config.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/test_e2e_args.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/test_e2e_config.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/test_link.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/tests/test_resources.py (0 hunks)
  • deploy/sdk/tests/test_deployment.sh (0 hunks)
💤 Files with no reviewable changes (42)
  • deploy/sdk/docs/cli/README.md
  • deploy/sdk/docs/sdk/README.md
  • deploy/sdk/src/dynamo/sdk/core/protocol/init.py
  • deploy/sdk/src/dynamo/sdk/lib/init.py
  • deploy/sdk/src/dynamo/sdk/tests/config.yaml
  • deploy/sdk/src/dynamo/sdk/core/runner/init.py
  • deploy/sdk/src/dynamo/sdk/cli/Dockerfile.template
  • deploy/sdk/src/dynamo/sdk/lib/image.py
  • CODEOWNERS
  • deploy/sdk/src/dynamo/sdk/core/init.py
  • deploy/sdk/tests/test_deployment.sh
  • deploy/sdk/src/dynamo/sdk/cli/cli.py
  • deploy/sdk/src/dynamo/sdk/cli/run_executable.py
  • deploy/sdk/src/dynamo/sdk/tests/test_link.py
  • deploy/sdk/README.md
  • deploy/sdk/src/dynamo/sdk/cli/run.py
  • deploy/sdk/src/dynamo/sdk/tests/test_resources.py
  • deploy/sdk/src/dynamo/sdk/lib/exceptions.py
  • deploy/sdk/src/dynamo/sdk/tests/test_e2e_config.py
  • deploy/sdk/src/dynamo/sdk/tests/test_e2e_args.py
  • deploy/sdk/src/dynamo/sdk/lib/decorators.py
  • deploy/sdk/src/dynamo/sdk/init.py
  • deploy/sdk/src/dynamo/sdk/lib/config.py
  • deploy/sdk/src/dynamo/sdk/cli/serve.py
  • deploy/sdk/src/dynamo/sdk/tests/pipeline.py
  • deploy/sdk/src/dynamo/sdk/lib/utils.py
  • deploy/sdk/src/dynamo/sdk/core/decorators/endpoint.py
  • deploy/sdk/src/dynamo/sdk/cli/allocator.py
  • deploy/sdk/src/dynamo/sdk/core/runner/common.py
  • deploy/sdk/src/dynamo/sdk/core/runner/health.py
  • deploy/sdk/src/dynamo/sdk/cli/env.py
  • deploy/sdk/src/dynamo/sdk/core/protocol/deployment.py
  • deploy/sdk/src/dynamo/sdk/core/lib.py
  • deploy/sdk/src/dynamo/sdk/tests/test_config.py
  • deploy/sdk/src/dynamo/sdk/core/runner/dynamo.py
  • deploy/sdk/src/dynamo/sdk/lib/loader.py
  • deploy/sdk/src/dynamo/sdk/cli/circus.py
  • deploy/sdk/src/dynamo/sdk/cli/serve_dynamo.py
  • deploy/sdk/src/dynamo/sdk/cli/serving.py
  • deploy/sdk/src/dynamo/sdk/core/protocol/interface.py
  • deploy/sdk/src/dynamo/sdk/lib/resource.py
  • deploy/sdk/src/dynamo/sdk/cli/utils.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ishandhanani ishandhanani changed the title chore: remove CODEOWNERS and sdk/ chore: sdk/ Jul 16, 2025
@ishandhanani ishandhanani changed the title chore: sdk/ chore: removesdk/ Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants