Repository navigation
fix: add nats and etcd values for helm chart deployment - #188
Closed
biswapanda wants to merge 1 commit into
Closed
biswapanda wants to merge 1 commit into
biswapanda wants to merge 1 commit into
Conversation
biswapanda
requested review from
hhzhang16,
hutm,
ishandhanani and
julienmancuso
as code owners
March 16, 2025 04:55
nnshah1
approved these changes
Mar 16, 2025
Comment on lines
+7
to
+11
| readinessProbe: | ||
| enabled: false | ||
|
|
||
| livenessProbe: | ||
| enabled: false No newline at end of file |
Contributor
There was a problem hiding this comment.
why do we disable liveness probes? these are very helpful tools to bring up a working system.
Contributor
|
@julienmancuso , can you review this MR and confirm if these changes need to get in? |
julienmancuso
requested changes
Apr 4, 2025
julienmancuso
left a comment
julienmancuso
left a comment
Contributor
There was a problem hiding this comment.
we don't need these.
these properties are part of the values.yaml
saturley-hall
force-pushed
the
bis/deploy-nats-etcd
branch
from
April 11, 2025 03:28
05f5435 to
71e192a
Compare
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
add nats and etcd values for helm chart deployment
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)