-
Notifications
You must be signed in to change notification settings - Fork 690
fix: update v1 docs #1849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update v1 docs #1849
Conversation
WalkthroughThe installation instructions in the vLLM example's README were updated from a simple pip command to a step-by-step process involving cloning the repository, checking out a specific commit, and installing with custom flags. An additional note was added regarding uninstalling a previous package for certain container users. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
examples/vllm_v1/README.md (1)
52-52: Polish wording & wrap the uninstall command in a code fenceMinor readability nit:
- Missing comma after the adverb clause.
- The raw single quotes around the command are unnecessary; use a proper code block instead.
-If you are in the default vllm container remember to uninstall the old vllm using 'uv pip uninstall ai-dynamo-vllm' +If you are using the default vLLM container, remember to uninstall the old package: + +```bash +uv pip uninstall ai-dynamo-vllm +```
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
examples/vllm_v1/README.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
examples/vllm_v1/README.md
46-46: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - vllm
9f110a6 to
2cc1c39
Compare
Overview:
Fixes NVBUG - https://nvbugspro.nvidia.com/bug/5382948
Summary by CodeRabbit