Repository navigation
Conversation
Signed-off-by: Matthew Wittwer <mwittwer@nvidia.com> Signed-off-by: furionw <qiwa@nvidia.com> Co-authored-by: Qi Wang <qiwa@nvidia.com> (cherry picked from commit 26d0133) Signed-off-by: furionw <qiwa@nvidia.com>
furionw
marked this pull request as ready for review
November 4, 2026 21:05
furionw
enabled auto-merge (squash)
November 4, 2026 23:20
Contributor
✅ Dynamo PR CI passed — run 41912640634 (attempt 2) on
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Backport of #17236 to
release/1.7.0, which is in QA. Today dynamo.frontend sends MiniMax M3 and M3.1 deployments in defaultautomode through the legacy V1 parser. That parser holds adaptive answer text until generation completes, so a client sees no content deltas before the end, and the held text is lost if the backend fails mid-stream. This routes M3 through the V2 UnifiedParser instead, keeps V1 as the rollback, and reads the reasoning state from the rendered prompt.This is a clean cherry-pick of
26d0133cf6: the added and removed lines are identical to the source commit. Only context lines differ, in two files, because this branch does not have #17586.Key Changes
Core logic is 88 added lines on the source PR, excluding tests, comments and whitespace.
automode selects the V2 UnifiedParser and recognizes M3 reasoning and tool markers.Validation
dynamo-llmunit tests, built with--no-default-features(filters:unified_parser,preprocessor,tool_choice,aggregator)pre-commiton the four changed filesA review of the diff found no correctness problem in the added lines. It found one gap specific to this branch, the logprobs behavior under Issues below, which comes from #17586 being absent here.
Not rerun on this branch: the four live Qwen generation probes on a stock vLLM 0.32.0 server that the source PR reports. Release-branch CI for head
45188e3f68passed on run attempt 2, which was a rerun with no code change. In attempt 1, two test jobs were cut off before pytest recorded an exit code, and a vLLM image build was cancelled at its time limit.Issues and Ongoing Work
Refs DIS-3197
mainas26d0133cf6. Target:release/1.7.0.dynamo-parsers-v20.9.6 already contains. This branch already pins 0.9.6, so there is no dependency change.release/1.7.0. The V2 parser re-attaches per-token logprobs only with fix(frontend): preserve chat token IDs and EOS logprobs #17586, which fix(frontend): preserve chat token IDs and EOS logprobs #18085 backports. Without it, M3 inautomode would returnlogprobs: nullon alogprobs=truerequest, where the V1 parser returned scores. CI on this branch ran without fix(frontend): preserve chat token IDs and EOS logprobs #18085, because the branch was cut before it landed. GitHub reports this PR as mergeable against the currentrelease/1.7.0, but the combined result has not been run through CI. SettingDYN_PARSER_VERSION=1on dynamo.frontend stays on V1.Pull Request Checklist
/pr-checklistskill.🤖 Generated with Claude Code