chore(CODEOWNERS): Make *.rs and Cargo.toml lists the same
#1811
Conversation
We need a rust reviewers alias. And add devops to the two entries that had only one person. We should't have single-owner entries, even though admins can always override.
WalkthroughThe CODEOWNERS file was updated to revise ownership assignments for various files and directories, including Rust files, example directories, and CI/CD PowerShell workflow scripts. Additional users and teams were added as owners, and a clarifying comment was modified. No application logic or exported entities were affected. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CODEOWNERS(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
CODEOWNERS (1)
Learnt from: PeaBrane
PR: ai-dynamo/dynamo#1409
File: examples/router_standalone/worker.py:171-186
Timestamp: 2025-06-08T08:30:45.126Z
Learning: Example code in the `examples/` directory may intentionally use hard-coded values or simplified implementations that wouldn't be appropriate for production code, but are acceptable for demonstration and testing purposes.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Mirror Repository to GitLab
- GitHub Check: Build and Test - vllm
- GitHub Check: copyright-checks
- GitHub Check: pre-commit
🔇 Additional comments (2)
CODEOWNERS (2)
21-21: Good catch adding DevOps as a secondary owner.This removes the single-point-of-failure on
/examples/common/. No further action required.
32-32: Consistent CI/CD ownership – looks correct.Adding
@ai-dynamo/Devopsalongside the script author keeps workflow maintenance unblocked.
| # Rust - Keep these two the same. Or better make an alias like devops have. | ||
| *.rs @ryanolson @grahamking @paulhendricks @biswapanda @tmonty12 @guanluo @rmccorm4 @alec-flowers @kkranen @oandreeva-nv @ai-dynamo/Devops @jthomson04 @PeaBrane | ||
| Cargo.toml @ryanolson @grahamking @paulhendricks @biswapanda @tmonty12 @guanluo @rmccorm4 @kkranen @oandreeva-nv @ai-dynamo/Devops | ||
| Cargo.toml @ryanolson @grahamking @paulhendricks @biswapanda @tmonty12 @guanluo @rmccorm4 @alec-flowers @kkranen @oandreeva-nv @ai-dynamo/Devops @jthomson04 @PeaBrane |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Consider replacing the long per-user lists with a dedicated Rust team alias.
*.rs and Cargo.toml now repeat 14 individual handles plus @ai-dynamo/Devops.
Maintaining two hard-coded, duplicated lists is error-prone (easy to get out of sync, exceeds GitHub’s 15-reviewer suggestion limit, and forces manual updates when a member changes).
Option:
-*.rs @ryanolson @grahamking … @PeaBrane
-Cargo.toml @ryanolson @grahamking … @PeaBrane
+# Rust sources & manifests
+*.rs @ai-dynamo/rust
+Cargo.toml @ai-dynamo/rust(where @ai-dynamo/rust is an org team that mirrors the current list).
This keeps the “two patterns, one owner list” rule in place while centralising membership to GitHub team management.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Rust - Keep these two the same. Or better make an alias like devops have. | |
| *.rs @ryanolson @grahamking @paulhendricks @biswapanda @tmonty12 @guanluo @rmccorm4 @alec-flowers @kkranen @oandreeva-nv @ai-dynamo/Devops @jthomson04 @PeaBrane | |
| Cargo.toml @ryanolson @grahamking @paulhendricks @biswapanda @tmonty12 @guanluo @rmccorm4 @kkranen @oandreeva-nv @ai-dynamo/Devops | |
| Cargo.toml @ryanolson @grahamking @paulhendricks @biswapanda @tmonty12 @guanluo @rmccorm4 @alec-flowers @kkranen @oandreeva-nv @ai-dynamo/Devops @jthomson04 @PeaBrane | |
| # Rust - Keep these two the same. Or better make an alias like devops have. | |
| # Rust sources & manifests | |
| *.rs @ai-dynamo/rust | |
| Cargo.toml @ai-dynamo/rust |
🤖 Prompt for AI Agents
In the CODEOWNERS file around lines 6 to 8, replace the repeated long lists of
individual user handles for `*.rs` and `Cargo.toml` with a single GitHub team
alias such as `@ai-dynamo/rust`. This involves creating a dedicated Rust team in
the GitHub organization that includes all current members, then updating both
lines to reference this team alias instead of listing each user individually.
This change centralizes membership management and avoids duplication.
There was a problem hiding this comment.
Yes, this would be ideal. How do I make that @ai-dynamo/rust "org team"?
There was a problem hiding this comment.
@grahamking Here's how to create the @ai-dynamo/rust GitHub organization team:
Creating the GitHub Team
- Navigate to your organization: Go to https://github.com/ai-dynamo
- Access Teams: Click the "Teams" tab at the top of the organization page
- Create new team: Click the green "New team" button
- Configure the team:
- Team name:
rust(this creates the@ai-dynamo/rusthandle) - Description: Something like "Rust code reviewers and maintainers"
- Visibility: Choose "Visible" (recommended for code review teams)
- Parent team: Leave empty unless you want to nest it under another team
- Team name:
Adding Members
After creating the team, add all current Rust reviewers:
- @ryanolson, @grahamking, @paulhendricks, @biswapanda, @tmonty12
- @GuanLuo, @rmccorm4, @alec-flowers, @kkranen, @oandreeva-nv
- @jthomson04, @PeaBrane
You can:
- Add individually: Search and add each member through the team's "Members" tab
- Bulk invite: Use the "Add members" button and paste usernames
Permissions & Settings
- Team permissions: No special repository permissions needed since CODEOWNERS handles review assignments
- Team discussions: Enable if you want team-specific discussions
- Team visibility: Keep as "Visible" so it can be referenced in CODEOWNERS
After Team Creation
Once the team exists, you can update the CODEOWNERS file to use:
*.rs @ai-dynamo/rust
Cargo.toml @ai-dynamo/rust
The team will automatically handle member management, and you can add/remove people through GitHub's team interface instead of editing CODEOWNERS repeatedly.
We need a rust reviewers alias.
And add devops to the two entries that had only one person. We should't have single-owner entries, even though admins can always override.
Summary by CodeRabbit
/examples/common/directory, and CI/CD PowerShell workflow scripts.