Repository navigation
Conversation
Contributor
✅ Dynamo PR CI passed — run 41941699952 (attempt 2) on
|
yifjiang
force-pushed
the
codex/kv-reuse-d25-gpu-transfer-lifetimes
branch
from
November 4, 2026 08:16
aaef6b1 to
47a838e
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d24-gpu-endpoint-ownership
branch
2 times, most recently
from
November 4, 2026 08:28
0a75f9e to
6d04be5
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d25-gpu-transfer-lifetimes
branch
from
November 4, 2026 08:28
47a838e to
9b58003
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d24-gpu-endpoint-ownership
branch
from
November 4, 2026 08:34
6d04be5 to
b253b02
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d25-gpu-transfer-lifetimes
branch
2 times, most recently
from
November 4, 2026 08:54
964ce23 to
c6bfb00
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d24-gpu-endpoint-ownership
branch
from
November 4, 2026 08:54
b253b02 to
ab1e14f
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d25-gpu-transfer-lifetimes
branch
from
November 4, 2026 20:39
c6bfb00 to
4f425bf
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d24-gpu-endpoint-ownership
branch
from
November 4, 2026 20:39
ab1e14f to
211b7c1
Compare
1 similar comment
Contributor
Author
|
/ok to test 4f425bf |
Signed-off-by: Yifan Jiang <19356972+yifjiang@users.noreply.github.com>
yifjiang
force-pushed
the
codex/kv-reuse-d25-gpu-transfer-lifetimes
branch
from
November 5, 2026 00:24
4f425bf to
ff0c1f0
Compare
Contributor
Author
|
/ok to test ff0c1f0 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One primary pin spans all rank parts, completion waits for every worker, cleanup is serialized, uncertain native shutdown cannot release live storage.
Review slice D25 of #16748; part of #16747 and #16746. This draft targets
codex/kv-reuse-d24-gpu-endpoint-ownershipfor a complete incremental review diff of 392 additions plus deletions, including tests, documentation and extraction glue.Extraction details:
Reuse remains experimental and default off. Retained inventory is advisory, complete compatible rank parts must precede readiness, and native operations retain ownership until quiescence. Supported GPU activation also requires the companion KVCR/native slices and the declared deployment profile.
Validation
All configured pre-commit hooks passed for this exact slice on allocated SLURM. Stack-level CPU regression coverage is summarized on D31; each draft still requires its own applicable CI in the Checks tab. Historical combined-head and hardware results retain their original source scope.