Skip to content

feat(kvbm): validate every bank before importing the selected rank [D22] - #18040

Draft
yifjiang wants to merge 1 commit into
codex/kv-reuse-d21-complete-rank-groupsfrom
codex/kv-reuse-d22-validate-rank-imports
Draft

yifjiang wants to merge 1 commit into
codex/kv-reuse-d21-complete-rank-groupsfrom
codex/kv-reuse-d22-validate-rank-imports

Conversation

@yifjiang

@yifjiang yifjiang commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Reject wrong rank, geometry, symlink, UUID/incarnation and stale descriptors before importing handles; no partial group acceptance.

Review slice D22 of #16748; part of #16747 and #16746. This draft targets codex/kv-reuse-d21-complete-rank-groups for a complete incremental review diff of 364 additions plus deletions, including tests, documentation and extraction glue.

Extraction details:

  • The complete rank import implementation replaces the functional TP1-only path; no rank group was served before this gate.

Reuse remains experimental and default off. Retained inventory is advisory, complete compatible rank parts must precede readiness, and native operations retain ownership until quiescence. Supported GPU activation also requires the companion KVCR/native slices and the declared deployment profile.

Validation

All configured pre-commit hooks passed for this exact slice on allocated SLURM. Stack-level CPU regression coverage is summarized on D31; each draft still requires its own applicable CI in the Checks tab. Historical combined-head and hardware results retain their original source scope.

@github-actions github-actions Bot added feat backend::vllm Relates to the vllm backend labels Nov 4, 2026
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d22-validate-rank-imports branch 2 times, most recently from 09b4900 to ec2f1df Compare November 4, 2026 08:28
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d21-complete-rank-groups branch 2 times, most recently from 8afab87 to e1baed0 Compare November 4, 2026 08:34
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d22-validate-rank-imports branch from ec2f1df to 4275ecc Compare November 4, 2026 08:34
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d21-complete-rank-groups branch from e1baed0 to 849007d Compare November 4, 2026 08:54
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d22-validate-rank-imports branch from 4275ecc to 3926129 Compare November 4, 2026 08:54
@devin-ai-integration

devin-ai-integration Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

⏹️ Dynamo PR CI cancelled — run 41941692280 (attempt 1) on cf67181d3b

Gate checks: ❌ backend-status-check · ✅ deploy-status-check · ✅ dynamo-status-check

Framework Build
vLLM ⏹️ 1 ✅ 5
SGLang ⏹️ 1

Failure details

No job failed; 2 multi-arch image builds were cancelled mid-build after ~59 minutes each, and backend-status-check fails only because it mirrors them.

  • ⏹️ sglang-runtime / Build multi-arch cuda13.0: cancelled in Build and Push Image while still in the linux/arm64 stage (##[error]The operation was canceled. after 3561 s). No earlier failures and the rest of the run continued, so this is not fail-fast; the ~1 h duration suggests a job time limit rather than a manual/concurrency cancel.
  • ⏹️ vllm-runtime-efa / Build multi-arch cuda13.0: same pattern, cancelled in Build and Push Image during the linux/arm64 pre_runtime stage after 3549 s.
For agents
{"pr": 18040, "run_id": 41941692280, "run_attempt": 1, "head_sha": "cf67181d3bad248854c458cc5c9fd1b11e762dcd",
 "failures": [
  {"job": "sglang-runtime / Build multi-arch cuda13.0", "job_id": 126964028609, "failed_step": "Build and Push Image", "signature": "cancelled after ~59 min during linux/arm64 build", "tests": [], "log_cmd": "gh run view --job 126964028609 -R ai-dynamo/dynamo --log-failed"},
  {"job": "vllm-runtime-efa / Build multi-arch cuda13.0", "job_id": 126964028828, "failed_step": "Build and Push Image", "signature": "cancelled after ~59 min during linux/arm64 build", "tests": [], "log_cmd": "gh run view --job 126964028828 -R ai-dynamo/dynamo --log-failed"}
 ]}

Posted automatically by Devin for run 41941692280. Updated on every full-CI run of this PR.

@yifjiang
yifjiang force-pushed the codex/kv-reuse-d21-complete-rank-groups branch from 849007d to 5fe6b39 Compare November 4, 2026 20:39
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d22-validate-rank-imports branch from 3926129 to 436022d Compare November 4, 2026 20:39
@copy-pr-bot

copy-pr-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

yifjiang commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 436022d

Signed-off-by: Yifan Jiang <19356972+yifjiang@users.noreply.github.com>
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d22-validate-rank-imports branch from 436022d to cf67181 Compare November 5, 2026 00:24
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d21-complete-rank-groups branch from 5fe6b39 to a5d4b23 Compare November 5, 2026 00:24
@yifjiang

yifjiang commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test cf67181

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend::vllm Relates to the vllm backend feat size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant