Skip to content

feat(kvbm): validate fabric identity and collect optional GPU tests [D15] - #18033

Draft
yifjiang wants to merge 1 commit into
codex/kv-reuse-d14-dispatch-ownershipfrom
codex/kv-reuse-d15-fabric-identities
Draft

yifjiang wants to merge 1 commit into
codex/kv-reuse-d14-dispatch-ownershipfrom
codex/kv-reuse-d15-fabric-identities

Conversation

@yifjiang

@yifjiang yifjiang commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Pure fabric identities and domain separation before native loading; optional dependency absence must not hide unrelated import errors or skip the stdlib suite.

Review slice D15 of #16748; part of #16747 and #16746. This draft targets codex/kv-reuse-d14-dispatch-ownership for a complete incremental review diff of 378 additions plus deletions, including tests, documentation and extraction glue.

Reuse remains experimental and default off. Retained inventory is advisory, complete compatible rank parts must precede readiness, and native operations retain ownership until quiescence. Supported GPU activation also requires the companion KVCR/native slices and the declared deployment profile.

Validation

All configured pre-commit hooks passed for this exact slice on allocated SLURM. Stack-level CPU regression coverage is summarized on D31; each draft still requires its own applicable CI in the Checks tab. Historical combined-head and hardware results retain their original source scope.

@github-actions github-actions Bot added feat backend::vllm Relates to the vllm backend labels Nov 4, 2026
@devin-ai-integration

devin-ai-integration Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

⏹️ Dynamo PR CI cancelled — run 41941659926 (attempt 1) on 2f130ddec9

Gate checks: ❌ backend-status-check · ❌ deploy-status-check · ✅ dynamo-status-check

Framework Build Deploy
vLLM ⏹️ 1 ✅ 5 ⏹️ 2 ✅ 2

Failure details

No jobs failed; 3 jobs were cancelled (the two red gate checks only mirror these cancels). Since nothing failed before them, these are not fail-fast cancels; they look like a manual/concurrency cancel (or a job time limit on the ~1h build). Rerunning the cancelled jobs should be enough.

For agents
{"pr": 18033, "run_id": 41941659926, "run_attempt": 1, "head_sha": "2f130ddec997136f2592a2b5cdfa251054440793",
 "failures": [],
 "cancelled": [{"job": "vllm-local-dev / Build multi-arch cuda13.0", "job_id": 126963928959, "step": "Build and Push Image"},
               {"job": "vllm Deploy Test / agg", "job_id": 126980617512, "step": "Run Dynamo Deploy Test"},
               {"job": "vllm Deploy Test / agg_router", "job_id": 126980617493, "step": "Run Dynamo Deploy Test"}]}

Posted automatically by Devin for run 41941659926. Updated on every full-CI run of this PR.

@yifjiang
yifjiang force-pushed the codex/kv-reuse-d14-dispatch-ownership branch from 08c6a61 to af2de2f Compare November 4, 2026 08:16
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d15-fabric-identities branch 2 times, most recently from 11b0b2c to b7d2837 Compare November 4, 2026 08:34
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d14-dispatch-ownership branch 2 times, most recently from 871af6b to edb2fe7 Compare November 4, 2026 08:54
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d15-fabric-identities branch 2 times, most recently from 09788de to 91dfab4 Compare November 4, 2026 20:39
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d14-dispatch-ownership branch from edb2fe7 to 408f61d Compare November 4, 2026 20:39
@copy-pr-bot

copy-pr-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

yifjiang commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 91dfab4

Signed-off-by: Yifan Jiang <19356972+yifjiang@users.noreply.github.com>
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d14-dispatch-ownership branch from 408f61d to 5e8356c Compare November 5, 2026 00:24
@yifjiang
yifjiang force-pushed the codex/kv-reuse-d15-fabric-identities branch from 91dfab4 to 2f130dd Compare November 5, 2026 00:24
@yifjiang

yifjiang commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 2f130dd

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend::vllm Relates to the vllm backend feat size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant