Repository navigation
Conversation
Contributor
✅ Dynamo PR CI passed — run 41941643671 (attempt 2) on
|
yifjiang
force-pushed
the
codex/kv-reuse-d11-bounded-lookups
branch
from
November 4, 2026 08:16
930f359 to
87510bb
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d10-source-eligibility
branch
from
November 4, 2026 08:16
27d640b to
60e8ce6
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d11-bounded-lookups
branch
2 times, most recently
from
November 4, 2026 20:39
66e8c36 to
fded18a
Compare
Contributor
Author
|
/ok to test fded18a |
Signed-off-by: Yifan Jiang <19356972+yifjiang@users.noreply.github.com>
yifjiang
force-pushed
the
codex/kv-reuse-d11-bounded-lookups
branch
from
November 5, 2026 00:24
fded18a to
7e7acd1
Compare
Contributor
Author
|
/ok to test 7e7acd1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Owned prompt copies, deadlines, blocking-pool saturation and departure handling; query-only paths never book decode capacity.
Review slice D11 of #16748; part of #16747 and #16746. This draft targets
codex/kv-reuse-d10-source-eligibilityfor a complete incremental review diff of 485 additions plus deletions, including tests, documentation and extraction glue.Extraction details:
Reuse remains experimental and default off. Retained inventory is advisory, complete compatible rank parts must precede readiness, and native operations retain ownership until quiescence. Supported GPU activation also requires the companion KVCR/native slices and the declared deployment profile.
The lower-tier lookup helpers compile with their optional standalone-selection consumers. D12 additionally exposes the GPU helpers to their default unit tests; no test function is gated or skipped by this correction.
Validation
All configured pre-commit hooks passed for this exact slice on allocated SLURM. Stack-level CPU regression coverage is summarized on D31; each draft still requires its own applicable CI in the Checks tab. Historical combined-head and hardware results retain their original source scope.