Repository navigation
Conversation
Contributor
✅ Dynamo PR CI passed — run 41941629596 (attempt 1) on
|
yifjiang
force-pushed
the
codex/kv-reuse-d07-source-hints
branch
from
November 4, 2026 08:16
bd81425 to
507f77b
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d08-calibrated-config
branch
2 times, most recently
from
November 4, 2026 20:39
438a8ac to
eeba55d
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d07-source-hints
branch
from
November 4, 2026 20:39
507f77b to
c3368a9
Compare
Contributor
Author
|
/ok to test eeba55d |
…re defaults Signed-off-by: Yifan Jiang <19356972+yifjiang@users.noreply.github.com>
yifjiang
force-pushed
the
codex/kv-reuse-d07-source-hints
branch
from
November 5, 2026 00:24
c3368a9 to
a07b8a9
Compare
yifjiang
force-pushed
the
codex/kv-reuse-d08-calibrated-config
branch
from
November 5, 2026 00:24
eeba55d to
942e02b
Compare
Contributor
Author
|
/ok to test 942e02b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Independent CPU/GPU costs, validation, settings, and the exact advertisement/checksum projection; in-memory values stay intact. The existing Python binding constructor retains the new Rust defaults until D30 supplies all eight explicit kwargs.
Review slice D08 of #16748; part of #16747 and #16746. This draft targets
codex/kv-reuse-d07-source-hintsfor a complete incremental review diff of 417 additions plus deletions, including tests, documentation and extraction glue.Reuse remains experimental and default off. Retained inventory is advisory, complete compatible rank parts must precede readiness, and native operations retain ownership until quiescence. Supported GPU activation also requires the companion KVCR/native slices and the declared deployment profile.
A dedicated retained-transfer YAML fixture checks all eight reuse settings. The shared Rust/Python fixture keeps the accepted schema until D30 extends the Python API and shared fixture together.
Validation
All configured pre-commit hooks passed for this exact slice on allocated SLURM. Stack-level CPU regression coverage is summarized on D31; each draft still requires its own applicable CI in the Checks tab. Historical combined-head and hardware results retain their original source scope.
At this exact D08 head, all 56 scheduling configuration tests passed, including the dedicated eight-setting fixture and unchanged legacy shared-fixture regression. Full Cargo formatting, all-target router Clippy and isolated indexer/slot feature checks also passed.