Repository navigation
Conversation
Signed-off-by: William Arnold <warnold@nvidia.com> Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
/ok to test e5f56de |
This was referenced Nov 2, 2026
Contributor
✅ Dynamo PR CI passed — run 41409733214 (attempt 1) on
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Adds the backend-neutral migration hooks for native
/generateformats, split out of #16977 so SGLang and vLLM migration can each land on top independently. No format turns migration on in this PR: SGLang and vLLM both bind withmigration: Err(..), so runtime behavior is unchanged.Details:
GenerateExchange::migrate(delivered_tokens, &mut PreprocessedRequest): the format rebases its request for a retry, or returns a terminalLLMEngineOutputwithout calling another worker.Bound.migration: Result<(), String>: the format's admission decision;Errkeeps the request on one worker.RequestContinuationonPreprocessedRequest(frontend-only, not serialized) lets the genericMigrationoperator call back into the format.Migration::for_generateandbuild_generate_pipelinewire the operator into the format pipeline.Worker.engine_info+ENGINE_INFO_KEY: worker-advertised engine metadata (e.g. sampling defaults) available at bind time.Where should the reviewer start?
lib/llm/src/generate_format.rs, thenlib/llm/src/migration.rsandlib/llm/src/http/service/format_generate.rs.Stack: SGLang migration #16977 and vLLM migration #17766 are rebased on this PR.
Related Issues