Skip to content

docs: fix the unavailable v1.5.0 contributor profile link - #17091

Merged
rmccorm4 merged 1 commit into
ai-dynamo:mainfrom
xianlubird:codex/fix-dead-contributor-link
Oct 23, 2026
Merged

rmccorm4 merged 1 commit into
ai-dynamo:mainfrom
xianlubird:codex/fix-dead-contributor-link

Conversation

@xianlubird

@xianlubird xianlubird commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The contributor profile https://github.com/Spycsh returns HTTP 404 and fails the repository-wide Docs link check on main and unrelated PRs such as #17005.

Keep @Spycsh in the v1.5.0 contributor acknowledgments as plain text and remove only the unavailable hyperlink. This is a one-line documentation change; link-check exclusions remain unchanged.

Closes #17087.

Validation

  • Scoped docs lint passed with zero errors; five existing navigation warnings concern other pages.
  • lychee 0.24.2 checked all 46 remaining contributor profile links with the CI accepted-status configuration: 46 OK, zero errors.
  • git diff --check passed.
  • Pinned Fern 5.80.2 configuration/internal-link checks were attempted but report missing publish-time-generated Python/Rust API pages in the clean checkout. No successful full Fern check is claimed.

The GNU Make links that separately timed out in #17005 currently return HTTP 200, so this PR does not change or exempt them.

Summary by CodeRabbit

  • Documentation
    • Updated the Dynamo v1.5.0 release notes so the Intel contributor’s name appears as plain text rather than a clickable GitHub profile link. This changes how the contributor entry is presented; the name is no longer linked to an external profile.

Signed-off-by: xianlubird <xianlubird@gmail.com>
@xianlubird
xianlubird requested a review from a team as a code owner October 22, 2026 07:58
@copy-pr-bot

copy-pr-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@xianlubird
xianlubird temporarily deployed to external_collaborator October 22, 2026 07:58 — with GitHub Actions Inactive
@xianlubird
xianlubird temporarily deployed to external_collaborator October 22, 2026 07:58 — with GitHub Actions Inactive
@github-actions github-actions Bot added docs external-contribution Pull request is from an external contributor trusted-contributor Org-External user who is trusted to run CI without Org-member approval labels Oct 22, 2026
@dynamo-ops

Copy link
Copy Markdown
Contributor

/ok to test 494b145

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 22, 2026
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 5df849a and 494b145.

📒 Files selected for processing: 1
  • docs/fern/pages/reference/general/releases/dynamo-v1-5-0.mdx

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The v1.5.0 release note now displays @Spycsh as plain text instead of linking to the unavailable GitHub profile.

Changes

Release note update

Layer / File(s) Summary
Contributor credit
docs/fern/pages/reference/general/releases/dynamo-v1-5-0.mdx
The contributor handle @Spycsh is plain text instead of a GitHub profile link.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 494b1

The change preserves the contributor credit while removing the unavailable profile link and is ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the documentation fix for the unavailable v1.5.0 contributor profile link.
Description check Passed The description explains the problem, scope, validation results, limitations, and linked issue. It does not use every template heading, but it provides the required information and identifies the affe…
Linked Issues check Passed The directly linked issue [#17087] requires preserving @Spycsh as contributor text while removing its unavailable GitHub profile link. The supplied PR evidence reports a one-line change in `docs/fer…
Out of Scope Changes check Passed The supplied change summary contains only the contributor-entry hyperlink removal. The change is directly related to [#17087]. The PR reports no link-check ignore change and no unrelated release-conte…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Description check

Explanation

The description explains the problem, scope, validation results, limitations, and linked issue. It does not use every template heading, but it provides the required information and identifies the affected v1.5.0 contributor acknowledgment.

Full details: Linked Issues check

Explanation

The directly linked issue [#17087] requires preserving @Spycsh as contributor text while removing its unavailable GitHub profile link. The supplied PR evidence reports a one-line change in docs/fern/pages/reference/general/releases/dynamo-v1-5-0.mdx that makes this exact change. It also reports that link-check exclusions remain unchanged.

Full details: Out of Scope Changes check

Explanation

The supplied change summary contains only the contributor-entry hyperlink removal. The change is directly related to [#17087]. The PR reports no link-check ignore change and no unrelated release-content change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

@devin-ai-integration

Copy link
Copy Markdown
Contributor

✅ Dynamo PR CI passed — run 39744322521 (attempt 1) on 494b14589c

Gate checks: ✅ backend-status-check · ✅ deploy-status-check · ✅ dynamo-status-check

Posted automatically by Devin for run 39744322521. Updated on every full-CI run of this PR.

@rmccorm4
rmccorm4 merged commit 47a1197 into ai-dynamo:main Oct 23, 2026
104 checks passed
@rmccorm4

Copy link
Copy Markdown
Contributor

Thank you @xianlubird !

This branch was previously deployed

1 inactive deployment
external_collaborator — 494b1458 Deployed Oct 22, 2026 by xianlubird via ok-to-test #37143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs documentation Improvements or additions to documentation external-contribution Pull request is from an external contributor size/XS trusted-contributor Org-External user who is trusted to run CI without Org-member approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: unavailable contributor profile breaks release-note link checking

4 participants