Repository navigation
Conversation
Signed-off-by: neilkg <33635204+neilkg@users.noreply.github.com>
neilkg
temporarily deployed
to
external_collaborator
October 19, 2026 14:27 — with
GitHub Actions
Inactive
neilkg
temporarily deployed
to
external_collaborator
October 19, 2026 14:27 — with
GitHub Actions
Inactive
Contributor
|
👋 Hi neilkg! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
Signed-off-by: neilkg <33635204+neilkg@users.noreply.github.com>
neilkg
temporarily deployed
to
external_collaborator
October 19, 2026 15:04 — with
GitHub Actions
Inactive
Signed-off-by: neilkg <33635204+neilkg@users.noreply.github.com>
neilkg
temporarily deployed
to
external_collaborator
October 19, 2026 15:17 — with
GitHub Actions
Inactive
Signed-off-by: neilkg <33635204+neilkg@users.noreply.github.com>
neilkg
temporarily deployed
to
external_collaborator
October 19, 2026 15:37 — with
GitHub Actions
Inactive
neilkg
temporarily deployed
to
external_collaborator
October 19, 2026 17:02 — with
GitHub Actions
Inactive
Signed-off-by: neilkg <33635204+neilkg@users.noreply.github.com>
neilkg
temporarily deployed
to
external_collaborator
October 19, 2026 18:23 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Beam does not support non-thinking generation, but a request with
chat_template_kwargs: {"enable_thinking": false}currently makes Dynamo move the model's analysis into answer content and report zero reasoning tokens.thinking: falsehas the same effect.Reject an effective client request to disable Beam reasoning with an actionable HTTP 400 before prompt rendering or backend dispatch. Reuse the existing alias normalization, including top-level
thinkingandreasoning_effort: "none", without introducing another switch or changing precedence. Validate before deployment defaults so the error describes the client's request. Omitted effort andreasoning_effort: nullremain accepted; the string"none"requests reasoning off.Use a shared
reasoning_is_mandatorymodel policy for both request validation and response reconstruction; Beam is the only family registered by this change. The generic validator reuses the existing family selection and thinking-alias normalization. Reconstructed Beam responses retain their analysis/content split and reasoning-token accounting even if an older request bypassed admission validation.Other model families and Beam's existing history behavior remain unchanged: supplied reasoning is preserved,
preserve_thinking=falseretains its compatibility behavior, and the default forallow_missing_thinkingis unchanged. Requiring reasoning in every historical assistant message is a separate serving policy from rejecting an explicit request to disable future reasoning.Targets
luckyq/beam-1.0-release, the Beam integration branch used by #16702. This is a frontend fix and does not require changes to the inference engines or parser crate.Closes #16783.
Validation
cargo test -p dynamo-llm --no-default-features --lib beam: 24 passed.cargo test -p dynamo-llm --no-default-features --lib reasoning_effort: 5 passed.cargo test -p dynamo-llm --no-default-features --lib reasoning_usage: 4 passed.cargo fmt --all -- --check, changed-file pre-commit hooks, andgit diff --check: passed.