Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -234,4 +234,4 @@ strip = false

# Post-codefreeze AISimulate source pin for release/1.6.0.
[patch.crates-io]
aisimulate-core = { git = "https://github.com/ai-dynamo/aisimulate.git", rev = "221b8163825c2526a9d050a0813d03a538c32e8e" }
aisimulate-core = { git = "https://github.com/ai-dynamo/aisimulate.git", rev = "6b12a7dfbac64a985e32d03039187cf751197e0f" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pin adds the required public field prefill_context_parallel_size to ReplayEngineConfig and ReplayRoleConfig, but lib/mocker/src/engine_adapter.rs still initializes both structs without it. Consequently the dynamo-mocker workspace member fails to compile with E0063.

🤖 AI Fix

Populate prefill_context_parallel_size in every ReplayEngineConfig and ReplayRoleConfig literal in lib/mocker/src/engine_adapter.rs, using 1 where no configurable value exists.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This revision adds the required public field prefill_context_parallel_size to both ReplayEngineConfig and ReplayRoleConfig, but Dynamo's lib/mocker/src/engine_adapter.rs still constructs these structs with literals that omit it. Building dynamo-mocker against this pin therefore fails with Rust E0063 in the aggregated setup and both disaggregated role setups. Update those literals when advancing the dependency, using 1 until Mocker exposes prefill context parallelism.

🤖 AI Fix

Add prefill_context_parallel_size: 1 to every affected ReplayEngineConfig and ReplayRoleConfig literal in lib/mocker/src/engine_adapter.rs.

14 changes: 7 additions & 7 deletions lib/bindings/kvbm/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/bindings/kvbm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,4 @@ cudarc = { version = "=0.19.8", features = ["cuda-version-from-build-system", "f

# Post-codefreeze AISimulate source pin for release/1.6.0.
[patch.crates-io]
aisimulate-core = { git = "https://github.com/ai-dynamo/aisimulate.git", rev = "221b8163825c2526a9d050a0813d03a538c32e8e" }
aisimulate-core = { git = "https://github.com/ai-dynamo/aisimulate.git", rev = "6b12a7dfbac64a985e32d03039187cf751197e0f" }
14 changes: 7 additions & 7 deletions lib/bindings/python/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/bindings/python/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,4 @@ strip = false

# Post-codefreeze AISimulate source pin for release/1.6.0.
[patch.crates-io]
aisimulate-core = { git = "https://github.com/ai-dynamo/aisimulate.git", rev = "221b8163825c2526a9d050a0813d03a538c32e8e" }
aisimulate-core = { git = "https://github.com/ai-dynamo/aisimulate.git", rev = "6b12a7dfbac64a985e32d03039187cf751197e0f" }
Loading