fix: add missing await in vllm-v1 clear_kv_blocks endpoint

[willkill07]

Overview:

This PR adds a missing await for an async function call. The embedded subprocess vllm-v1 clear_kv_blocks endpoint should await the required call. I discovered this when trying to use the endpoint.

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability of clearing cached data during certain operations.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[github-actions]

👋 Hi willkill07! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

[coderabbitai]

Walkthrough

The asynchronous method clear_kv_blocks in the RequestHandler class was updated to await the reset_prefix_cache method call on self.engine_client, ensuring it is handled asynchronously. No changes were made to method signatures or exported entities.

Changes

File(s)	Change Summary
launch/dynamo-run/src/subprocess/vllm_v1_inc.py	Modified clear_kv_blocks to await reset_prefix_cache asynchronously.

Possibly related PRs

• feat: add endpoint to clear all kv blocks in vllm v1 #1384: Introduced the clear_kv_blocks async method and its endpoint, which is directly modified in this PR.

Poem

A hop and a skip, async we go,
Awaiting the cache, nice and slow.
No more blocking, swift and neat,
CodeRabbit’s rhythm, hard to beat!
With every await, the bugs take flight—
The engine’s cache now clears just right.
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e84b1e7 and 5bcacf5.

📒 Files selected for processing (1)

• launch/dynamo-run/src/subprocess/vllm_v1_inc.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: pre-merge-rust (lib/bindings/python)
• GitHub Check: pre-merge-rust (lib/runtime/examples)
• GitHub Check: Build and Test - vllm
• GitHub Check: pre-merge-rust (.)

🔇 Additional comments (1)

launch/dynamo-run/src/subprocess/vllm_v1_inc.py (1)

129-129: LGTM! Correctly fixes the missing await.

The addition of await before self.engine_client.reset_prefix_cache() is the correct fix. Since engine_client is an AsyncLLM instance and the clear_kv_blocks method is async, the reset_prefix_cache() method call should be awaited to ensure proper asynchronous execution.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[PeaBrane]

@jain-ria can you check this should be awaited?

[jain-ria]

Yes, there should be an await