fix: remove http endpoint for clearing kv blocks - #1629
Merged
Conversation
jain-ria
force-pushed
the
rjain/clear-kv-blocks
branch
from
June 24, 2025 22:36
5274738 to
60a0f14
Compare
jain-ria
marked this pull request as ready for review
June 25, 2025 15:37
jain-ria
requested review from
GuanLuo,
alec-flowers,
biswapanda,
grahamking,
kkranen,
oandreeva-nv,
paulhendricks,
rmccorm4,
ryanolson and
tmonty12
as code owners
June 25, 2025 15:37
yao531441
pushed a commit
to yao531441/dynamo
that referenced
this pull request
May 13, 2026
Merged
5 tasks
nnshah1
added a commit
that referenced
this pull request
Jun 10, 2026
- Drop POST /clear_kv_blocks from env-var docs (it's not a registered route) and delete the orphaned lib/llm/src/http/service/clear_kv_blocks.rs source file (dead since PR #1629 removed the route registration; no mod declaration, so it wasn't even compiled). - Rename State::new_with_flags -> State::new_with_nvext_enabled (only one flag for now). - Collapse the 6-line copy-pasted comment block at the 3 openai.rs handler call sites to a one-liner; rewrite the if/else as an expression assignment. - Trim const docs in environment_names.rs to behavior + default; the EPP/GAIE/Prime-RL compatibility paragraph is design rationale and lives in the PR description, not the public env-var reference. - Trim the env-mirror comment, the field/accessor doc duplication, and switch the admin-API-disabled log to structured fields. - Add two tests: enable_nvext propagates through the builder onto State.nvext_enabled (default + on + off), and enable_admin_api=false causes GET /busy_threshold to 404 while /live still serves 200. Signed-off-by: nnshah1 <neelays@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)