Skip to content

perf(trtllm): isolate sidecar request shutdown waiters #16082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jthomson04 merged 1 commit into from
Oct 12, 2026
Merged

perf(trtllm): isolate sidecar request shutdown waiters #16082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sidecar/trtllm/src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ impl LLMEngine for TrtllmSidecarEngine {
// streamed chunk costs a boxed future and a waker registration on every
// token.
let mut request_cancellation = Box::pin(async move { stopped_ctx.stopped().await });
let shutdown = self.cancel.clone();
let shutdown = self.cancel.child_token();
let mut shutdown_cancellation = Box::pin(async move { shutdown.cancelled().await });

// The same deferral applies here, not just to the streaming loop below.
Expand Down
Loading