Repository navigation
Conversation
…rocessor Signed-off-by: bin <bin.pan@daocloud.io>
Contributor
|
👋 Hi flpanbin! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
flpanbin
force-pushed
the
fix/vllm-processor-invalid-argument-500
branch
from
October 9, 2026 13:58
b4b2b3a to
99ab0d0
Compare
flpanbin
force-pushed
the
fix/vllm-processor-invalid-argument-500
branch
from
October 9, 2026 14:49
99ab0d0 to
ea14084
Compare
flpanbin
force-pushed
the
fix/vllm-processor-invalid-argument-500
branch
from
October 9, 2026 15:11
ea14084 to
5f6de53
Compare
flpanbin
marked this pull request as ready for review
October 9, 2026 15:23
Contributor
| } | ||
| } | ||
|
|
||
| /// Walks the error chain for an `InvalidRequest` and returns |
There was a problem hiding this comment.
This private helper's doc comment mostly restates the loop and return value, and the only lasting security point about not promoting diagnostic text is already documented immediately above for the same conversion path. Remove the redundant narration rather than adding another copy of the rule.
🤖 AI Fix
Delete this three-line doc comment.
… dispatch Signed-off-by: bin <bin.pan@daocloud.io>
flpanbin
force-pushed
the
fix/vllm-processor-invalid-argument-500
branch
from
October 10, 2026 01:36
5f6de53 to
d353d86
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #15305. With
--dyn-chat-processor vllm, a worker that rejects a request with a typedInvalidArgumentreaches the Python chat processor as a generic error, and the client gets an opaque500 Internal server errorinstead of a 400 carrying the worker's message. Two layers drop the error's identity:RoutedEngine.generate()flattened failures viato_pyerr, keeping only theDisplaytext and discarding the source chain — so Python never receives a typed exception.VllmProcessor's genericexcept Exceptionrelies on aBackendInvalidArgument:prefix check that matches nothing since refactor(errors): unify semantic error classification #14395 changed the errorDisplayto the normalized class name.Changes
lib/bindings/python/rust/errors.rs— newsemantic_to_pyerr: walk the source chain; if a classifiedDynamoErrorisInvalidRequestwith an explicitly public message, raise typed PythonInvalidArgumentwith that message.lib/bindings/python/rust/llm/routed_engine.rs— use it at theRoutedEngine.generate()dispatch boundary.components/src/dynamo/frontend/vllm_processor.py— re-raise typedInvalidArgumentahead of the generic handler.errors.rsandtest_vllm_processor_unit.pylib/llm/src/kv_router/prefill_router/mod.rs,components/src/dynamo/vllm/handlers.py.Validation
Unit tests:
E2E:
using a multimodal request against multimodal-disabled workers as the rejection scenario (frontend with
--dyn-chat-processor vllm):500 {"message":"Internal server error",...}400 {"message":"Received multimodal data but multimodal processing is not enabled. Use --enable-multimodal flag to enable multimodal processing.","type":"Bad Request","code":400}Related Issues
--dyn-chat-processor vllm#15990Summary by CodeRabbit