Repository navigation
feat(model): add shared NGC fetching support with vLLM/SGLang integration #15441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
31bd51e
feat(model): add shared NGC fetching support with vLLM/SGLang integra…
sunil1511 9434f42
fix: pre-commit error and add docstrings
sunil1511 30646e0
fix: review comments
sunil1511 48af879
fix: move weights download to post arg validation and add model sourc…
sunil1511 5f3e687
Merge branch 'main' into sunil1511/ngc-model-fetching
sunil1511 ce964d4
fix: preserve model identity across cache locations with regression c…
sunil1511 499e6d1
Merge branch 'main' into sunil1511/ngc-model-fetching
sunil1511 529e546
Merge branch 'main' into sunil1511/ngc-model-fetching
sunil1511 6875f90
Merge branch 'main' into sunil1511/ngc-model-fetching
sunil1511 228ded5
Merge branch 'main' into sunil1511/ngc-model-fetching
rmccorm4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Tests for identifying model sources that engines cannot resolve themselves.""" | ||
|
|
||
| import pytest | ||
|
|
||
| from dynamo.common.model_fetch import needs_local_model_path | ||
|
|
||
| pytestmark = [pytest.mark.pre_merge, pytest.mark.unit, pytest.mark.gpu_0] | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("model", "expected"), | ||
| [ | ||
| ("ngc://nvstaging/nim/nemotron-3-ultra:hf-rl-052726-nvfp4-e9744cc", True), | ||
| ("Qwen/Qwen3-0.6B", False), | ||
| ("/data/llms/Qwen3-0.6B", False), | ||
| ], | ||
| ) | ||
| def test_needs_local_model_path(model: str, expected: bool) -> None: | ||
| assert needs_local_model_path(model) is expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.