Skip to content

fix(recipes): use default TCP transport for Kimi aggregated KV routing - #15428

Merged
sara4dev merged 2 commits into
mainfrom
codex/kimi-agg-tcp-request-plane
Sep 30, 2026
Merged

sara4dev merged 2 commits into
mainfrom
codex/kimi-agg-tcp-request-plane

Conversation

@sara4dev

@sara4dev sara4dev commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Remove --request-plane nats from the Kimi-K2.5 aggregated Eagle3/KV-router recipe's frontend and worker so both use the default TCP request transport. Preserve the default ZMQ event transport, 24-GPU topology, engine settings, and benchmark.

Validation

  • YAML parsing, recipe catalog validation, docs lint, and scoped pre-commit checks passed.
  • Static validation only; no deployment or GPU run.

Related Issues

Related to #15361 and OPS-8639.

Summary by CodeRabbit

  • Chores
    • Updated the deployment configuration for the Kimi K2.5 inference service. This change adjusts how the service is configured at deployment time; no changes to user-facing features or behavior are noted.

Signed-off-by: Saravana Periyasamy <saperiyasamy@nvidia.com>
Signed-off-by: Saravana Periyasamy <saperiyasamy@nvidia.com>
@sara4dev sara4dev changed the title fix(recipes): use TCP requests for Kimi aggregated KV routing fix(recipes): use default TCP transport for Kimi aggregated KV routing Sep 30, 2026
@sara4dev
sara4dev marked this pull request as ready for review September 30, 2026 17:08
@sara4dev
sara4dev requested review from a team as code owners September 30, 2026 17:08
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: ai-dynamo/dynamo/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a6f34ca8-28bd-4b72-b879-9e92129ec894

📥 Commits

Reviewing files that changed from the base of the PR and between 9949fea and 2700924.

📒 Files selected for processing (1)
  • recipes/kimi-k2.5/trtllm/agg-eagle-kv-router/deploy.yaml
💤 Files with no reviewable changes (1)
  • recipes/kimi-k2.5/trtllm/agg-eagle-kv-router/deploy.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review.


Walkthrough

The deployment configuration removes --request-plane nats from the Frontend and agg worker arguments. The Frontend retains --router-mode kv; the worker retains its other arguments.

Changes

Deployment arguments

Layer / File(s) Summary
Remove request-plane arguments
recipes/kimi-k2.5/trtllm/agg-eagle-kv-router/deploy.yaml
The Frontend and agg worker arguments no longer specify --request-plane nats. The Frontend retains --router-mode kv.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 27009

The recipe now uses the default TCP request transport for Kimi aggregated KV routing. No concrete merge-blocking risk was identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the recipe change and the switch to the default TCP transport for Kimi aggregated KV routing.
Description check ✅ Passed The description explains the change, validation performed, and related issues. It does not use the template headings and omits the required “Where should the reviewer start?” section. The related issu…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@sara4dev
sara4dev merged commit 8ad295a into main Sep 30, 2026
108 of 109 checks passed
@sara4dev
sara4dev deleted the codex/kimi-agg-tcp-request-plane branch September 30, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants