Repository navigation
fix: stop CODEOWNERS edits from requesting every owner - #15244
Conversation
GitHub requests every team on the last matching line. The generated file listed every codeowner group, so any edit paged all of them. Signed-off-by: Dan Gil <dagil@nvidia.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: ai-dynamo/dynamo/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe ownership configuration removes the shared CODEOWNERS rule. Comments specify process-area ownership, and a regression test checks that CODEOWNERS resolves only to the process team. ChangesCODEOWNERS ownership
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to CODEOWNERS edits now request only the process team. No issue requiring a change before merge was identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.)
Comment |
dmitry-tokarev-nv
left a comment
There was a problem hiding this comment.
Not approving yet. The one finding is a P2, but it asks you to choose who approves routing changes. My approval alone meets every code-owner rule on this PR, so I will wait for that choice. If the next head has either fix from the inline comment and no new defect, I will approve it.
Read at 12f60317d5, and merged locally with main at a6a2001f06.
- [P2]
.github/codeowners/areas.yaml:563-565: the comment says that ops or process can unblock a routing change. After this PR, only a process approval does. - No path other than
CODEOWNERSchanges owners. The codeowners gates pass on this head and on the merge. The new test fails on a copy that restores the removed rule. - The change that the bot asks for at
test_codeowners.py:1140is optional. Its reference to pull request 15170 is accurate, and.ai/linear-ticket-refs.mdallows GitHub numbers in code comments.
dmitry-tokarev-nv
left a comment
There was a problem hiding this comment.
Approving at 12f60317d5. I accept process as the only approver of changes to the generated CODEOWNERS. That settles the choice that my earlier review asked for.
The evidence is in that review. Only CODEOWNERS changes owners. The gates pass on the head and on a merge with main. The new test fails on the base. Since then, main gained 4 commits, and none of them touches CODEOWNERS or .github/codeowners/.
One item stays open. The comment at .github/codeowners/areas.yaml:563-565 still says that ops or process can unblock a routing change. Please reword it to say that a process approval is required. That thread stays open for it.
|
/ok to test 12f6031 |
dmitry-tokarev-nv
left a comment
There was a problem hiding this comment.
I approve again at 106868b038, the merge of main into this branch. The merge changed none of the three files in this PR, and one P2 is still open.
The merge also changed nothing under .github/codeowners/ or in the codeowners workflow. The codeowners job passes on this head. The new test still fails on the old CODEOWNERS from main, so it still guards this fix.
[P2], still open: the comment at .github/codeowners/areas.yaml:563-565 says that ops or process can unblock a routing change. After this PR, only a process approval can. The inline thread stays open for it.
A routing change regenerates CODEOWNERS, which process owns alone, so an ops approval no longer unblocks one. Signed-off-by: Dan Gil <dagil@nvidia.com>
dmitry-tokarev-nv
left a comment
There was a problem hiding this comment.
I approve this PR at d309d6fd28. The new commit fixes my last open finding, and no finding of mine is open.
What I checked at d309d6fd28.
The commit changes only comment lines in .github/codeowners/areas.yaml. The parsed file is the same as at 106868b038, and CODEOWNERS and CONTRIBUTORS.md did not change.
The new comment is correct. The matcher of the repository gives process as the only owner of CODEOWNERS, and ops and process as the owners of areas.yaml. So only a process approval covers a routing change.
The unit tests (158 pass), build_codeowners.py --strict, and the drift check pass on this head. They also pass on its merge with main at 86d68a4856. The codeowners job passes on this head.
|
Admin merge at |
Overview:
Editing CODEOWNERS requested every codeowner group. GitHub requests every team on the last matching line, and that line named all of them.
Details:
Where should the reviewer start?
.github/codeowners/areas.yamlRelated Issues
🚫 This PR is NOT linked to an issue:
Summary by CodeRabbit