Repository navigation
fix(ci): skip DGDR deploy tests without planner image - #15201
xianlubird wants to merge 3 commits into
Conversation
Signed-off-by: xianlubird <xianlubird@gmail.com>
|
/ok to test b9da294 |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: ai-dynamo/dynamo/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe pull request updates ChangesPlanner workflow updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to DGDR changes trigger the planner workflow, and deployment tests run only after a successful image copy with a valid tag. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
|
/ok to test 19cad4f |
|
/ok to test e2452a2 |
dmitry-tokarev-nv
left a comment
There was a problem hiding this comment.
I approve e2452a270c2c9c7352dd7cc665ba4aa6aa5fbeba. It has no P0, P1, or P2 defect. Two P3 items follow.
main already has most of this change. Commit 3079ce52 (#15394) adds the same dgdr condition to planner-build. It also runs deploy-test-dgdr only after planner-copy-to-acr succeeds. This head merges into main at 522096a8e666 with no conflict. After that merge, this PR adds only the two conditions below.
- [P3] The merge with
mainrepeatsneeds.planner-copy-to-acr.result == 'success'..github/workflows/pr.yaml:1570(lines 1585 and 1588 after the merge). Please mergemainand remove the repeated line. Ifmainis enough, please close this PR instead. - [P3] The
image_tag != ''test changes a missing Planner tag into a silent skip..github/workflows/pr.yaml:1571. Ifplanner-copy-to-acrsucceeds with an empty tag, no DGDR test runs, anddeploy-status-checkandbackend-status-checkboth pass. Please remove the line, or make an empty tag fail the DGDR job with a clear error.
No CI run covers the merge with main. The last PR run on this head is 35815040589, from 2026-09-23.
Five Planner cases: the DGDR tests run only in the last row, and `backend-status-check` fails for a cancelled or failed build.
The results are the same at this head and on the merge with main at 522096a8e666. Each row assumes that deploy-operator succeeds. Rows 1, 2, 4, and 5 also assume a change that sets operator or dgdr.
| Planner build | planner-copy-to-acr |
deploy-test-dgdr |
deploy-status-check |
backend-status-check |
|---|---|---|---|---|
| cancelled | skipped | skipped | passes | fails |
| failed | skipped | skipped | passes | fails |
| skipped | skipped | skipped | passes | passes |
| success, empty tag | success | skipped | passes | passes |
| success, tag set | success | runs | fails on a DGDR test failure | passes |
- The Planner build skips only for a change with no
core,planner,operator, ordgdrfile. Thendeploy-test-dgdralso skips, because its own condition needsoperatorordgdr. - On
mainwithout this PR, only the empty-tag row differs. The DGDR tests run with the imagedynamo-planner:and fail, sodeploy-status-checkfails. - The code in
shared-copy.ymlnever sets an empty tag. It writesimage_tagat line 97, or it exits 1 at line 91. - Run 35692044251 (#14681, before this fix) shows the cancelled case on the old code. The Planner build stopped at 60 minutes, the copy skipped, the three DGDR tests ran and failed, and both status checks failed.
deploy-status-check,backend-status-check, andplanner-copy-to-acrare the same in that run, at this head, and on the merge.- Run 35815040589 shows the last row on this head. The Planner build and the copy succeeded, and the three DGDR tests ran and passed.
- The other cells come from the
if:conditions, not from a run.
actionlint 1.7.12 gives the same 22 messages on `main`, on this head, and on the merge.
- The 22 messages are 21 unknown runner labels and the constant
if: falseonallure-report. Only the line numbers differ between the three trees. - A planted unknown job name in the new
if:adds one error. A planted missing)adds one error. - A planted unknown output name adds no error, because actionlint cannot read the outputs of a
$/workflow. I readimage_taginshared-copy.ymllines 36 to 38 instead.
|
Thanks, I checked main and confirmed #15394 already covers the DGDR planner build trigger and the copy-success gate. |
Summary
Why
In PR #14681's CI run, the Planner build was cancelled at its 60-minute limit. The Planner image copy was skipped, but the DGDR job still started with an empty image tag (
dynamo-planner:). The webhook then rejected DGDRs becausespec.imagehad no parseable version tag andspec.runtimeVersionOverridewas absent:The deploy status check then failed as a consequence. This PR prevents those secondary errors; it does not change the Planner build timeout.
Validation
.github/workflows/pr.yamlas YAML and checked the new dependency conditions.git diff --checkpassed.Where should the reviewer start?
The
planner-buildanddeploy-test-dgdrconditions in.github/workflows/pr.yaml.Related Issues
Summary by CodeRabbit