Repository navigation
test(deploy): preserve snapshot capture-source logs - #15076
Draft
MatejKosec wants to merge 1 commit into
Draft
MatejKosec wants to merge 1 commit into
MatejKosec wants to merge 1 commit into
Conversation
Signed-off-by: Matej Kosec <mkosec@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint capture Pods can disappear before deployment cleanup collects their logs. The checkpoint deployment test now discovers capture sources through SnapshotJobs, streams container logs and records Pod manifests while startup is in progress, and retries failed stream attachments. Cleanup cancels and awaits the collector and its streams before deleting the deployment.
This change was extracted from #13041 at the reviewer's request. All pre-commit checks and Python parsing passed, and stream cancellation was checked against the pinned Kubernetes client implementation. Live Kubernetes and GPU validation remain pending; this PR is a draft.