Repository navigation
chore(release): backport #15012 and #15019 to release/1.5.0 #15027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -634,16 +634,19 @@ COPY deploy/inference-gateway/ext-proc/ /opt/dynamo/deploy/inference-gateway/ext | ||||||||||
| {% if target == "planner" or (target == "runtime" and framework in ("vllm", "sglang", "trtllm")) %} | |||||||||||
| COPY container/deps/requirements.aisimulate.txt /opt/dynamo/container/deps/requirements.aisimulate.txt | |||||||||||
|
|
|||||||||||
| # AI Simulate is released separately as an abi3 wheel. Stage the exact published | |||||||||||
| # wheel consumed by ai-dynamo instead of rebuilding it from vendored source. | |||||||||||
| # Download only this distribution; runtime images own dependency installation | |||||||||||
| # through their requirements files and local wheels. | |||||||||||
| # AI Simulate is released separately as an abi3 wheel. Its public PyPI artifact | |||||||||||
| # is a small resolver sdist because the full wheel is too large for that registry; | |||||||||||
| # stage the actual wheel directly from NVIDIA's package index. Download only this | |||||||||||
| # distribution; runtime images own dependency installation through their | |||||||||||
| # requirements files and local wheels. | |||||||||||
| RUN --mount=type=cache,id=uv-root-{{ context.dynamo.uv_version }},target=/root/.cache/uv,sharing=shared \ | |||||||||||
| export UV_CACHE_DIR=/root/.cache/uv && \ | |||||||||||
| source ${VIRTUAL_ENV}/bin/activate && \ | |||||||||||
| python -m pip download \ | |||||||||||
| --only-binary=:all: \ | |||||||||||
| --no-deps \ | |||||||||||
| --no-index \ | |||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The 0.12.0 wheel is fetched from NVIDIA's index only for planner and framework-runtime targets, but the frontend target also runs on Python 3.12 and installs the top-level 🤖 AI FixStage the NVIDIA AISimulate wheel for the frontend target and install that local wheel before installing the top-level Dynamo wheel.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Premise does not hold. Verified by execution. The public PyPI artifact for Measured: clean Python 3.12 venv, default index only, plus the sdist that proves the mechanismThe sdist contains only four files. Its [build-system]
requires = ["wheel-stub"]
build-backend = "wheel_stub.buildapi"
[tool.wheel_stub]
index_url = "https://pypi.nvidia.com/"The staging step is different because it passes
|
|||||||||||
| --find-links https://pypi.nvidia.com/aisimulate/ \ | |||||||||||
| --dest /opt/dynamo/dist \ | |||||||||||
| --requirement /opt/dynamo/container/deps/requirements.aisimulate.txt | |||||||||||
| {% endif %} | |||||||||||
|
|
|||||||||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ license-files = ["LICENSE"] | |
| requires-python = ">=3.10" | ||
| dependencies = [ | ||
| "ai-dynamo-runtime==1.5.0", | ||
| "aisimulate==0.12.0.dev2; python_version >= '3.11' and python_version < '3.14'", | ||
| "aisimulate==0.12.0; python_version >= '3.11' and python_version < '3.14'", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The frontend image installs this meta wheel with dependency resolution, but the new release's full AISimulate wheel is only staged from NVIDIA's index in 🤖 AI FixInclude the frontend target in AISimulate wheel staging and pass the staged local wheel or wheelhouse as a resolver source when frontend.Dockerfile installs ai-dynamo.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Premise does not hold. Verified by execution. See the reply on the |
||
| "aiohttp>=3.14.3,<4.0", | ||
| "transformers>=4.56.0", | ||
| "kubernetes>=32.0.1,<33.0.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inline note only narrates that this timeout increase is temporary and should be investigated; the changed value already records the operative configuration, while the comment preserves no lasting constraint or actionable context.
🤖 AI Fix
Remove the inline temporary/TODO comment and leave the timeout value unchanged.