Skip to content

fix(sidecar): [cherry-pick 1.5.1] honor worker namespace suffix (#14955) - #15020

Merged
nv-nmailhot merged 2 commits into
ai-dynamo:release/1.5.1from
biswapanda:bis/cherry-pick-14955-release-1.5.0
Sep 28, 2026
Merged

nv-nmailhot merged 2 commits into
ai-dynamo:release/1.5.1from
biswapanda:bis/cherry-pick-14955-release-1.5.0

Conversation

@biswapanda

Copy link
Copy Markdown
Contributor

Summary

  • Cherry-picks fix(sidecar): honor worker namespace suffix #14955 (5a6d414575) onto release/1.5.0.
  • Makes Rust-side RL publishers compose DYN_NAMESPACE_WORKER_SUFFIX, matching frontend RL discovery and the Python worker path.
  • Preserves explicit CLI namespaces and avoids double-appending an existing suffix.

Fixes the namespace-registration asymmetry reported in NVIDIA bug 6731829.

Validation

  • cargo fmt --all
  • cargo test -p dynamo-backend-common --lib
  • cargo test -p dynamo-vllm-sidecar
  • cargo clippy -p dynamo-backend-common --all-targets -- -D warnings
  • GCP regression validation in nv-prd-dgxc.teleport.sh-dynamo-gcp-dev-02, namespace bis-rl-3 (in progress)

Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
(cherry picked from commit 5a6d414)
@biswapanda
biswapanda requested a review from a team as a code owner September 17, 2026 21:07
@copy-pr-bot

copy-pr-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@biswapanda
biswapanda deployed to external_collaborator September 17, 2026 21:07 — with GitHub Actions Active
@biswapanda
biswapanda deployed to external_collaborator September 17, 2026 21:07 — with GitHub Actions Active
@github-actions github-actions Bot added the fix label Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi biswapanda! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions Bot added the external-contribution Pull request is from an external contributor label Sep 17, 2026
@biswapanda biswapanda removed the external-contribution Pull request is from an external contributor label Sep 17, 2026
@biswapanda

Copy link
Copy Markdown
Contributor Author

/ok to test 97b25c7

@dagil-nvidia
dagil-nvidia marked this pull request as draft September 18, 2026 20:25
@dagil-nvidia

Copy link
Copy Markdown
Collaborator

Held for Dynamo 1.5.1. release/1.5.0 is closed at RC11, the 1.5.0 GA build, so this cherry-pick must not merge there. Converted to draft; it retargets to release/1.5.1 as soon as that branch is cut (patch targeted for 2026-09-30). Tracked on the Dynamo 1.5.1 cherry-pick canvas.

@dagil-nvidia dagil-nvidia changed the title fix(sidecar): honor worker namespace suffix fix(sidecar): [cherry-pick 1.5.1] honor worker namespace suffix (#14955) Sep 28, 2026
@dagil-nvidia
dagil-nvidia changed the base branch from release/1.5.0 to release/1.5.1 September 28, 2026 10:52
@dagil-nvidia
dagil-nvidia marked this pull request as ready for review September 28, 2026 10:52
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@dagil-nvidia
dagil-nvidia deployed to external_collaborator September 28, 2026 21:50 — with GitHub Actions Active
@dynamo-ops

Copy link
Copy Markdown
Contributor

Unsigned Commits Detected

The following commits are not GPG-signed and must be signed before CI can run:

Commit Reason
97b25c7 unsigned

Please sign your commits and push again. See the GitHub docs on commit signature verification for help.

@nv-nmailhot
nv-nmailhot merged commit 5e4d862 into ai-dynamo:release/1.5.1 Sep 28, 2026
27 of 28 checks passed

This branch was successfully deployed

1 active deployment
external_collaborator — 25cdfe60 Deployed Sep 28, 2026 by dagil-nvidia via ok-to-test #23452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants