Repository navigation
fix: Cherry-pick #14461 - #14954
fix: Cherry-pick #14461#14954yunzhoul-nv wants to merge 1 commit into
Conversation
Signed-off-by: Yunzhou (David) Liu <232973175+yunzhoul-nv@users.noreply.github.com>
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
| # carries neither flag, so both would leave this unchecked. parsed_args | ||
| # comes from ServerArgs.add_cli_args, which declares both options across | ||
| # the supported SGLang releases. | ||
| check_elastic_ep_backend( |
There was a problem hiding this comment.
The supported XPU image is pinned to SGLang v0.5.11 (container/context.yaml), while elastic EP support is only available in SGLang >=0.5.16. Its parser does not create these attributes, so every XPU SGLang worker now fails during parse_args with AttributeError even when elastic EP was never requested. Read the optional parser fields compatibly before invoking the preflight check.
🤖 AI Fix
Pass getattr(parsed_args, "elastic_ep_backend", None) and getattr(parsed_args, "enable_dp_attention", False) to check_elastic_ep_backend and add a parse-args regression test for the v0.5.11-style namespace.
|
|
||
|
|
||
| def _installed_mooncake_versions() -> Dict[str, str]: | ||
| """Map each installed mooncake distribution to its version.""" |
There was a problem hiding this comment.
This private helper's name and loop over _MOONCAKE_DISTRIBUTIONS already state that it maps installed distributions to versions.
🤖 AI Fix
Remove this docstring.
| extension_modules, | ||
| torch_version="2.11.0+cu130", | ||
| ): | ||
| """Pin every probe so the check runs against a known image shape.""" |
There was a problem hiding this comment.
This docstring only narrates the immediately following monkeypatch setup; the helper name and assignments already show that every probe is pinned.
🤖 AI Fix
Remove this docstring.
|
|
||
|
|
||
| def _simulate_broken_mooncake(monkeypatch, **overrides): | ||
| """An image whose mooncake ProcessGroup extension does not load.""" |
There was a problem hiding this comment.
This docstring restates _simulate_broken_mooncake and the fixture values directly below it without recording a non-obvious constraint.
🤖 AI Fix
Remove this docstring.
|
|
||
|
|
||
| def _simulate_healthy_mooncake(monkeypatch): | ||
| """An image whose mooncake ProcessGroup extension loads and registers.""" |
There was a problem hiding this comment.
This docstring repeats the helper name and the explicit successful-import/backend-registration fixture that follows.
🤖 AI Fix
Remove this docstring.
|
|
||
|
|
||
| def test_accepts_mooncake_when_the_image_can_serve_it(monkeypatch): | ||
| """Negative control: a working image is not blocked.""" |
There was a problem hiding this comment.
The test name and its healthy fixture plus successful call already express this negative control; the docstring adds no lasting rationale.
🤖 AI Fix
Remove this docstring.
|
|
||
|
|
||
| def _install_fake_sglang_sources(monkeypatch, tmp_path, import_line): | ||
| """Point the resolver at a source tree naming one ProcessGroup module.""" |
There was a problem hiding this comment.
This docstring merely expands the helper name; the created package tree and written import line make the setup self-explanatory.
🤖 AI Fix
Remove this docstring.
2 participants
Cherry-pick #14461