Repository navigation
fix(profiler): explain inaccessible model paths during trust checks (cherry-pick of #14860) - #14943
Merged
Merged
Conversation
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
| dgdr = _make_dgdr(modelCache=_pvc_model_cache(str(tmp_path), "model")) | ||
| assert resolve_model_path(dgdr) == _HF_ID | ||
|
|
||
| def test_inaccessible_pvc_config_during_materialization( |
There was a problem hiding this comment.
This case is redundant with the retained inaccessible-PVC regression coverage: resolve_model_path(dgdr) is evaluated before materialize_dgd is entered, so the blueprint/backend/materialization path cannot affect the outcome. test_run_profile_records_pvc_inspection_failure still verifies the same inaccessible config error is preserved instead of falling back to the Hub model, and additionally protects the profiler failure status that remains supported.
🤖 AI Fix
Remove TestResolveModelPath.test_inaccessible_pvc_config_during_materialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #14860 onto
release/1.5.0from merge commit8309ffb419ffbf8d0093fb8817f2625886ca3f45.Preserve PVC config inspection errors before model resolution can fall back to a Hugging Face ID, and report actionable directory/symlink ownership guidance when a local model path cannot be inspected for implicit trust. Keep missing-path fallback and explicit worker trust behavior, and correct the inconclusive auto-map warning.
The cherry-pick applied without conflicts and has the same stable patch ID as the main merge. Inaccessible paths still require corrected permissions/symlink ownership or an accessible snapshot path.
Validation
pre-commit run --all-files: passed.git diff --check: passed.-x.This PR has not yet been merged into the release. A release image rebuild and the original QA deployment/inference retest remain outstanding; local tests do not establish release CI completion.