Repository navigation
fix(discovery): backport served model aliases to 1.5 (#14857) - #14917
Merged
Merged
Conversation
Signed-off-by: jthomson04 <jwillthomson19@gmail.com> (cherry picked from commit a5c242e) Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
| } else if self.is_lora { | ||
| self.base_identity() == other.base_identity() | ||
| } else { | ||
| // Preserve existing same-name registration compatibility across local model paths. |
There was a problem hiding this comment.
This only restates the immediately following equal-display_name condition. “Existing” compatibility does not identify a lasting constraint beyond what the code already expresses.
🤖 AI Fix
Remove this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport #14857 to
release/1.5.0. Workers that use the same non-empty model source path can register different, non-overlapping served names on one endpoint. Each served name selects its own worker group. Base/LoRA name collisions remain rejected.Details
a5c242e8269737313bdac98ef82822e6f04b99b9; applied without conflicts. Production changes are unchanged from the source PR.DistributedConfig::response_planeand use the loopback interface name for the TCP response stream.Where should the reviewer start?
lib/runtime/src/discovery/mod.rsfor registration compatibility, then the regression tests inlib/runtime/src/discovery/mock.rsandlib/llm/src/discovery/watcher.rs.Related Issues
Validation
Run locally on the release backport with default test parallelism:
cargo test -p dynamo-runtime --no-default-features --lib discovery::mock::tests— 15 passed.cargo test -p dynamo-llm --no-default-features --lib discovery::watcher::tests— 23 passed. Includes two classify workers using file discovery and TCP requests, separate alias routing, and removal of one model registration.cargo fmt --all -- --checkandgit diff --check HEAD^ HEAD— passed.No GPU/vLLM end-to-end test was run.