Repository navigation
fix(router): backport unknown worker target validation to 1.5 (#14858) - #14915
Merged
Merged
Conversation
Signed-off-by: jthomson04 <jwillthomson19@gmail.com> (cherry picked from commit 5e21f9c) Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport #14858 to
release/1.5.0. An unknown effectivenvextworker target now returnsInvalidArgument(HTTP 400) at initial selection. The error identifies the field and rejected worker ID.Details
5e21f9c6181ad42ba4fb8a3e20bf7c2b62631724.routing_host/tests.rsby retaining both the release branch's shutdown/migration regression and the incoming explicit-worker tests. Useinstance_ids().contains()in one test becauseClient::is_instance_live()is absent on this release. Production changes are unchanged from the source PR.Where should the reviewer start?
lib/llm/src/kv_router/routing_host.rsfor target validation, thenprefill_router/mod.rsfor preview error propagation androuting_host/tests.rsfor regression coverage.Related Issues
Validation
Run locally on the release backport with default test parallelism and debug info disabled:
cargo test -p dynamo-llm --no-default-features --lib kv_router::routing_host::tests— 48 passed, including the retained shutdown/migration test.cargo test -p dynamo-llm --no-default-features --lib kv_router::prefill_router::— 33 passed.cargo test -p dynamo-llm --no-default-features --lib session_affinity::— 37 passed.cargo test -p dynamo-llm --no-default-features --lib http::service::openai::tests::— 130 passed.cargo fmt --all -- --checkandgit diff --check HEAD^ HEAD— passed.No GPU/vLLM end-to-end test was run.