Skip to content

fix(router): backport unknown worker target validation to 1.5 (#14858) - #14915

Merged
nv-nmailhot merged 2 commits into
release/1.5.0from
jthomson04/cp-14858-release-1.5.0
Sep 16, 2026
Merged

nv-nmailhot merged 2 commits into
release/1.5.0from
jthomson04/cp-14858-release-1.5.0

Conversation

@jthomson04

Copy link
Copy Markdown
Contributor

Summary

Backport #14858 to release/1.5.0. An unknown effective nvext worker target now returns InvalidArgument (HTTP 400) at initial selection. The error identifies the field and rejected worker ID.

Details

  • Cherry-pick of 5e21f9c6181ad42ba4fb8a3e20bf7c2b62631724.
  • Covers built-in and KV routing, prefill, and route previews. Preserve field precedence, LoRA selection, affinity handling, and service-error handling after selection.
  • Resolve one append conflict in routing_host/tests.rs by retaining both the release branch's shutdown/migration regression and the incoming explicit-worker tests. Use instance_ids().contains() in one test because Client::is_instance_live() is absent on this release. Production changes are unchanged from the source PR.

Where should the reviewer start?

lib/llm/src/kv_router/routing_host.rs for target validation, then prefill_router/mod.rs for preview error propagation and routing_host/tests.rs for regression coverage.

Related Issues

Validation

Run locally on the release backport with default test parallelism and debug info disabled:

  • cargo test -p dynamo-llm --no-default-features --lib kv_router::routing_host::tests — 48 passed, including the retained shutdown/migration test.
  • cargo test -p dynamo-llm --no-default-features --lib kv_router::prefill_router:: — 33 passed.
  • cargo test -p dynamo-llm --no-default-features --lib session_affinity:: — 37 passed.
  • cargo test -p dynamo-llm --no-default-features --lib http::service::openai::tests:: — 130 passed.
  • cargo fmt --all -- --check and git diff --check HEAD^ HEAD — passed.

No GPU/vLLM end-to-end test was run.

Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
(cherry picked from commit 5e21f9c)
Signed-off-by: jthomson04 <jwillthomson19@gmail.com>
@github-actions github-actions Bot added fix router Relates to routing, KV-aware routing, etc. labels Sep 16, 2026
@jthomson04
jthomson04 marked this pull request as ready for review September 16, 2026 15:54
@jthomson04
jthomson04 requested a review from a team as a code owner September 16, 2026 15:54
@nv-nmailhot
nv-nmailhot merged commit a3eacd9 into release/1.5.0 Sep 16, 2026
112 of 115 checks passed
@nv-nmailhot
nv-nmailhot deleted the jthomson04/cp-14858-release-1.5.0 branch September 16, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix router Relates to routing, KV-aware routing, etc. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants