Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ vllm-proto = { version = "=0.1.0" }
kube = { version = "2.0.1", default-features = false, features = ["client", "rustls-tls", "aws-lc-rs", "runtime"] }
k8s-openapi = { version = "0.26.0", features = ["v1_32"] }
rcgen = { version = "0.13" }
quinn = { version = "0.11.9", default-features = false, features = ["runtime-tokio", "rustls-ring"] }
quinn = { version = "0.11.12", default-features = false, features = ["runtime-tokio", "rustls-ring"] }
Comment thread
jthomson04 marked this conversation as resolved.
Resolved
sha2 = { version = "0.10" }
tokio-rustls = { version = "0.26" }
rustls = { version = "0.23", default-features = false, features = ["ring", "std"] }
Expand Down
8 changes: 4 additions & 4 deletions lib/bindings/kvbm/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions lib/bindings/python/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions lib/runtime/examples/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 23 additions & 4 deletions lib/runtime/src/pipeline/network/quic_response.rs
Original file line number Diff line number Diff line change
Expand Up @@ -932,8 +932,9 @@ async fn run_server_connection(
)
.await;
if let Err(error) = result {
tracing::warn!(connection_id, %error, "QUIC response lane failed; closing connection");
tracing::warn!(connection_id, error = format!("{error:#}"), close_reason = ?lane_connection.close_reason(), "QUIC response lane failed; closing connection");
fail_server_connection(&lane_state, connection_id);
// Close explicitly if the lane failed before bundle registration.
lane_connection
.close(CLOSE_CODE_INVARIANT, b"response lane invariant failure");
}
Expand Down Expand Up @@ -1848,14 +1849,23 @@ fn spawn_client_lane(
&writer_connections,
&writer_contexts,
&writer_healthy,
&error.to_string(),
bundle_id,
"writer",
&format!("{error:#}"),
);
}
});

tokio::spawn(async move {
if let Err(error) = run_client_control_reader(recv, contexts.clone()).await {
fail_client_connection_bundle(&connections, &contexts, &healthy, &error.to_string());
fail_client_connection_bundle(
&connections,
&contexts,
&healthy,
bundle_id,
"control_reader",
&format!("{error:#}"),
);
}
});
}
Expand Down Expand Up @@ -1946,13 +1956,22 @@ fn fail_client_connection_bundle(
connections: &[quinn::Connection],
contexts: &Mutex<HashMap<Uuid, Arc<ClientResponseContext>>>,
healthy: &AtomicBool,
bundle_id: Uuid,
failure_path: &'static str,
reason: &str,
) {
if !healthy.swap(false, Ordering::AcqRel) {
return;
}
crate::metrics::quic_response::record_bundle_failure("worker");
tracing::warn!(%reason, "QUIC response connection bundle invariant failed");
let remote = connections.first().map(quinn::Connection::remote_address);
tracing::warn!(
%bundle_id,
failure_path,
?remote,
%reason,
Comment thread
jthomson04 marked this conversation as resolved.
Resolved
"QUIC response connection bundle invariant failed"
);
for (_, entry) in contexts.lock().drain() {
entry.fail_registration(reason);
entry.record_cancellation();
Expand Down
Loading