Repository navigation
test(operator): align DGDR goldens with current AIC backend slot - #14836
Conversation
Signed-off-by: xianlubird <xianlubird@gmail.com>
|
/ok to test abc402b |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe test fixtures replace the pinned ChangesAIC backend version fixture updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This updates stale expected AIC backend versions without introducing unresolved production risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the change, impact, related context, validation, and testing limits. It does not include the required Related Issues section or the Where should the reviewer start? section. The description is otherwise complete and relevant. Resolution Add the required Related Issues section and select either the linked-issue option with the issue number or the no-related-issue confirmation. Add a Where should the reviewer start? section that identifies the files or changes reviewers should inspect first.
Comment |
Summary
Update the DGDR deployment, Grove, and LWS golden manifests to expect
--aic-backend-version current, matching the defaults introduced by #14541 when AISimulate moved to 0.12.0.dev1. This changes only the 17 expected argument values.Urgency and impact
This is a deterministic CI blocker for branches containing that upgrade which run Operator Integration with the updated production profiler image. The DGDR profiling integration test compares generated manifests against these stale expectations, so unrelated Operator changes can fail the same check. It needs a prompt merge to unblock those PRs. It does not imply all PRs or all Operator tests fail, and it is not an Operator production failure: the job is gated by the
operatorchanged-files filter and successful prerequisite builds.Evidence: completed Operator Integration failure on #14681. The mismatch is the expected
0.14.0versus actualcurrentinTestClusterDynamoGraphDeploymentRequestProfilesAndCreatesWorkloadManifests. The workload-blocking quota in the test is intentional.Related #14457 also edits these snapshots, but expects
0.24.0for an older AISimulate database; it does not synchronize them with the current defaults. This PR keeps the immediate CI repair separate from backend-version resolution changes.Validation
go test ./internal/testing/golden— passed.--aic-backend-versionchanged; all other content is identical.git diff --check— passed.make integrationrequires Kind and the production profiler/operator images and was not run locally; the linked CI diff provides the actual expected-value update.link #14681
Summary by CodeRabbit