Skip to content

test(operator): align DGDR goldens with current AIC backend slot - #14836

Merged
tedzhouhk merged 1 commit into
ai-dynamo:mainfrom
xianlubird:bug/operator-aic-current-goldens
Sep 15, 2026
Merged

tedzhouhk merged 1 commit into
ai-dynamo:mainfrom
xianlubird:bug/operator-aic-current-goldens

Conversation

@xianlubird

@xianlubird xianlubird commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Update the DGDR deployment, Grove, and LWS golden manifests to expect --aic-backend-version current, matching the defaults introduced by #14541 when AISimulate moved to 0.12.0.dev1. This changes only the 17 expected argument values.

Urgency and impact

This is a deterministic CI blocker for branches containing that upgrade which run Operator Integration with the updated production profiler image. The DGDR profiling integration test compares generated manifests against these stale expectations, so unrelated Operator changes can fail the same check. It needs a prompt merge to unblock those PRs. It does not imply all PRs or all Operator tests fail, and it is not an Operator production failure: the job is gated by the operator changed-files filter and successful prerequisite builds.

Evidence: completed Operator Integration failure on #14681. The mismatch is the expected 0.14.0 versus actual current in TestClusterDynamoGraphDeploymentRequestProfilesAndCreatesWorkloadManifests. The workload-blocking quota in the test is intentional.

Related #14457 also edits these snapshots, but expects 0.24.0 for an older AISimulate database; it does not synchronize them with the current defaults. This PR keeps the immediate CI repair separate from backend-version resolution changes.

Validation

  • go test ./internal/testing/golden — passed.
  • Parsed and compared all three YAML document streams against the base: exactly 17 values following --aic-backend-version changed; all other content is identical.
  • git diff --check — passed.
  • Full make integration requires Kind and the production profiler/operator images and was not run locally; the linked CI diff provides the actual expected-value update.

link #14681

Summary by CodeRabbit

  • Bug Fixes
    • Updated decode and prefill deployment configurations to use the current AIC backend version instead of a fixed older version.
    • Ensured generated deployment resources consistently reference the current backend version across supported deployment scenarios.

Signed-off-by: xianlubird <xianlubird@gmail.com>
@xianlubird
xianlubird requested a review from a team as a code owner September 15, 2026 02:10
@copy-pr-bot

copy-pr-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@xianlubird
xianlubird deployed to external_collaborator September 15, 2026 02:10 — with GitHub Actions Active
@xianlubird
xianlubird deployed to external_collaborator September 15, 2026 02:10 — with GitHub Actions Active
@github-actions github-actions Bot added the test label Sep 15, 2026
@dynamo-ops

Copy link
Copy Markdown
Contributor

/ok to test abc402b

@github-actions github-actions Bot added external-contribution Pull request is from an external contributor trusted-contributor Org-External user who is trusted to run CI without Org-member approval deployment::k8s Relates to dynamo deployment in kubernetes labels Sep 15, 2026
@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9520e6f1-3fe4-4704-9087-099c163edcec

📥 Commits

Reviewing files that changed from the base of the PR and between b113cea and abc402b.

📒 Files selected for processing (3)
  • deploy/operator/internal/controller/testdata/dgdr/deployment/output.yaml
  • deploy/operator/internal/controller/testdata/dgdr/grove/output.yaml
  • deploy/operator/internal/controller/testdata/dgdr/lws/output.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The test fixtures replace the pinned 0.14.0 AIC backend version with current for decode and prefill components and their generated resources across deployment, Grove, and LWS configurations.

Changes

AIC backend version fixture updates

Layer / File(s) Summary
Component argument updates
deploy/operator/internal/controller/testdata/dgdr/*/output.yaml
Decode and prefill component arguments now use current for the --aic-backend-version value.
Generated resource updates
deploy/operator/internal/controller/testdata/dgdr/*/output.yaml
Generated deployments, cliques, and LeaderWorkerSet containers now use current for the decode and prefill backend version.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to abc40

This updates stale expected AIC backend versions without introducing unresolved production risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change, impact, related context, validation, and testing limits. It does not include the required Related Issues section or the Where should the reviewer start? section. T… Add the required Related Issues section and select either the linked-issue option with the issue number or the no-related-issue confirmation. Add a Where should the reviewer start? section that identifies the files or changes reviewers shou…
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies a test change that aligns DGDR golden manifests with the current AIC backend version. It accurately describes the main change.
Full details: Description check

Explanation

The description explains the change, impact, related context, validation, and testing limits. It does not include the required Related Issues section or the Where should the reviewer start? section. The description is otherwise complete and relevant.

Resolution

Add the required Related Issues section and select either the linked-issue option with the issue number or the no-related-issue confirmation. Add a Where should the reviewer start? section that identifies the files or changes reviewers should inspect first.

  • Fix all pre-merge checks with AI

Comment @coderabbitai help to get the list of available commands.

@tedzhouhk
tedzhouhk merged commit 5292fc9 into ai-dynamo:main Sep 15, 2026
108 checks passed
@xianlubird
xianlubird deleted the bug/operator-aic-current-goldens branch September 16, 2026 00:54

This branch was successfully deployed

1 active deployment
external_collaborator — abc402b3 Deployed Sep 15, 2026 by xianlubird via pr_reminder #12704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment::k8s Relates to dynamo deployment in kubernetes external-contribution Pull request is from an external contributor size/M test trusted-contributor Org-External user who is trusted to run CI without Org-member approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants