Repository navigation
test(deploy): share chat and embedding API coverage #14681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmitry-tokarev-nv
merged 26 commits into
ai-dynamo:main
from
xianlubird:codex/deploy-api-coverage
Oct 9, 2026
+997
−93
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d95b086
fix(sglang): use embedding requests for worker canary checks
xianlubird c97491b
test(sglang): bound embedding handler unit tests
xianlubird f68dc2b
test(deploy): share chat and embedding API coverage
xianlubird 108e129
test(deploy): fix shared response contracts and endpoint routing
xianlubird 327737d
test(deploy): route shared helper tests through core CPU selection
xianlubird f9f8150
test(deploy): fix embedding mode and verify stop against baseline
xianlubird 80418f0
test(deploy): remove redundant null stop case
xianlubird 7e6abe8
test(sglang): deduplicate embedding health payload coverage
xianlubird 8cb3ad3
Merge embedding canary test cleanup into deploy API coverage
xianlubird 804ddad
test(deploy): remove redundant validator docstrings
xianlubird 5d09b41
chore: merge main into deploy API coverage
xianlubird 054dc25
chore: merge main into deploy API coverage
xianlubird 2f80e40
test(deploy): tighten API contracts and simplify check wiring
xianlubird cf52116
chore: merge main into deploy API coverage
xianlubird 368d5be
Merge branch 'main' into codex/deploy-api-coverage
xianlubird 2654467
ci(deploy): avoid Kubernetes E2E fan-out on core changes
xianlubird 9453730
test(deploy): tighten shared API checks
xianlubird 827833a
Merge branch 'main' into codex/deploy-api-coverage
xianlubird 6bb4ca1
fix(deploy): read typed KVCR chat response
xianlubird 63b35df
chore: merge main into deploy API coverage
xianlubird d8fe62d
fix(deploy): retry dropped streaming responses
xianlubird b955b60
Merge branch 'main' into codex/deploy-api-coverage
xianlubird 1df3b85
Merge branch 'main' into codex/deploy-api-coverage
xianlubird 74dd78a
chore: merge main into deploy API coverage
xianlubird de3fb23
fix(deploy): reuse reconnected port forwards across API checks
xianlubird b780508
chore: merge main and update deploy output helper import
xianlubird File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| apiVersion: nvidia.com/v1beta1 | ||
| kind: DynamoGraphDeployment | ||
| metadata: | ||
| name: sglang-agg-embed | ||
| spec: | ||
| components: | ||
| - name: Frontend | ||
| podTemplate: | ||
| spec: | ||
| containers: | ||
| - image: my-registry/sglang-runtime:my-tag | ||
| name: main | ||
| replicas: 1 | ||
| type: frontend | ||
| - name: decode | ||
|
xianlubird marked this conversation as resolved.
xianlubird marked this conversation as resolved.
|
||
| podTemplate: | ||
| spec: | ||
| containers: | ||
| - args: | ||
| - --embedding-worker | ||
| - --use-sglang-tokenizer | ||
| - --model-path | ||
| - Qwen/Qwen3-Embedding-0.6B | ||
|
xianlubird marked this conversation as resolved.
|
||
| - --served-model-name | ||
| - Qwen/Qwen3-Embedding-0.6B | ||
| - --page-size | ||
| - "16" | ||
| - --tp | ||
| - "1" | ||
| - --trust-remote-code | ||
| command: | ||
| - python3 | ||
| - -m | ||
| - dynamo.sglang | ||
| envFrom: | ||
| - secretRef: | ||
| name: hf-token-secret | ||
| image: my-registry/sglang-runtime:my-tag | ||
| name: main | ||
| resources: | ||
| limits: | ||
| nvidia.com/gpu: "1" | ||
| requests: | ||
| # Increase this value for larger models. | ||
| ephemeral-storage: 2Gi | ||
| workingDir: /workspace/examples/backends/sglang | ||
| replicas: 1 | ||
| type: worker | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.