Repository navigation
Conversation
|
/ok_to_test 6f2fe42 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughChangesTensor request output handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change propagates requested output names and parameters while preserving all-output behavior and rejecting invalid valueless parameters. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Comment |
|
The task could not be completed. Open the task for details or retry. |
cc2b735 to
1ef616e
Compare
1ef616e to
b7e2027
Compare
Forward ModelInferRequest.outputs (name and parameters) onto NvCreateTensorRequest so workers can honor classification and output selection. Signed-off-by: Yingge He <yinggeh@nvidia.com>
b7e2027 to
cbcc5aa
Compare
|
/ok to test cbcc5aa |
…ort-requested-outputs
|
/ok to test d786503 |
Summary
RequestedOutputandNvCreateTensorRequest.outputsso a tensor request can name which model outputs to return and carry per-output parameters.ModelInferRequest.outputs(including parameters such asclassification) in the gRPC tensor frontend. An empty list still means every model output.Validation
lib/llm/src/grpc/service/tensor.rs: parameters are preserved, emptyoutputsare omitted from JSON, and a valueless parameter is rejected asInvalidArgument.rustfmt --edition 2024on the two touched files.Summary by CodeRabbit
New Features
Bug Fixes