Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a37a9af
feat(sidecar): add e2e CI testing for sidecar launch scripts
tanmayv25 Sep 9, 2026
493bc7a
fix(sidecar): unblock CI and address review comments
tanmayv25 Sep 9, 2026
92d697c
fix(sidecar): fix image-build permission bug, improve sglang timeout …
tanmayv25 Sep 9, 2026
0c27d61
fix(sidecar): refresh baked-in launch scripts, harden shell injection…
tanmayv25 Sep 9, 2026
6111087
fix(sidecar): stop trusting a pre-set DYNAMO_HOME in launch scripts
tanmayv25 Sep 10, 2026
7190391
diag(tests): dump log tail on health-check timeout, not just on proce…
tanmayv25 Sep 10, 2026
33dd869
fix(sidecar): surface silent gRPC connection/health-check retry loops
tanmayv25 Sep 10, 2026
16f466e
ci(sidecar): install sidecar binaries into the backend's own test image
tanmayv25 Sep 10, 2026
fd937b3
ci(nightly): note the duplicated sidecar-marker exclusion as a TODO
tanmayv25 Sep 10, 2026
66b48b3
fix(ci): remove dangling needs on deleted sidecar-*-test-image jobs
tanmayv25 Sep 10, 2026
a4af4eb
ci(sidecar): scope GITHUB_TOKEN permissions on sidecar-*-test jobs
tanmayv25 Sep 10, 2026
f25a7f8
fix(ci): extract sidecar binaries via buildx local output, not docker cp
tanmayv25 Sep 11, 2026
6d65c65
ci: retrigger sidecar build (retry after suspected stale BuildKit cache)
tanmayv25 Sep 11, 2026
b0148ae
ci(sidecar): raise sidecar-build timeout to 90m
tanmayv25 Sep 11, 2026
ba0f2a5
fix(tests): surface real health-check failures, fix timeout margin
tanmayv25 Sep 11, 2026
668642c
fix(tests): surface HTTP response body in sidecar health-check failures
tanmayv25 Sep 11, 2026
f83dd17
ci: upload per-test log files on failure
tanmayv25 Sep 11, 2026
75ba58f
fix(trtllm): pin smg-grpc-proto to the version its proto was vendored…
tanmayv25 Sep 14, 2026
f3cf555
Merge remote-tracking branch 'origin/main' into worktree-e2e-sidecar-…
tanmayv25 Sep 14, 2026
421d618
ci: retrigger after merge (investigating pr.yaml startup_failure)
tanmayv25 Sep 14, 2026
6cfbb7e
fix(ci): add now-required framework: input to sidecar-*-test jobs
tanmayv25 Sep 14, 2026
4d37377
fix(sidecar): preserve vllm runtime setup in e2e tests
JulienDarve Sep 15, 2026
05ba5d3
fix(trtllm): make the smg-grpc-proto pin guard version-aware
tanmayv25 Sep 16, 2026
9550d60
fix(sidecar): fix pre-init logging gap and backend-failure fallback m…
tanmayv25 Sep 16, 2026
388c386
fix(sidecar): fix pre-init retry logging for vLLM, restore structured
tanmayv25 Sep 16, 2026
0dcb147
fix(sidecar): keep the error cause chain on the bootstrap-path retry log
tanmayv25 Sep 17, 2026
d95f932
fix(sidecar): keep the error cause chain on SGLang's connect retry path
tanmayv25 Sep 17, 2026
ac02b09
Merge branch 'main' into worktree-e2e-sidecar-tests
tanmayv25 Sep 17, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/nightly-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,10 @@ jobs:
enable_coverage: true
run_cpu_only_tests: true
cpu_only_test_markers: vllm and gpu_0
gpu_test_markers: vllm and gpu_1
# not sidecar: sidecar-marked tests need dynamo-vllm-sidecar layered onto
# the image (see pr.yaml's sidecar-vllm-test), which this plain
# vllm-runtime image doesn't have.
gpu_test_markers: vllm and gpu_1 and not sidecar
Comment thread
tanmayv25 marked this conversation as resolved.
Resolved
gpu_test_timeout_minutes: 240
# Profiled tests run in the parallel stage; unprofiled fall through to sequential.
# 24 GiB admits all currently profiled vLLM tests (max is ~20.4 GiB) on a 48 GiB GPU.
Expand Down Expand Up @@ -887,7 +890,7 @@ jobs:
platform: '["amd64"]'
enable_coverage: true
run_sanity_check: false
gpu_test_markers: vllm and (gpu_1 or gpu_2)
gpu_test_markers: vllm and (gpu_1 or gpu_2) and not sidecar
gpu_test_timeout_minutes: 240
# 80 GiB H100 admits more of the profiled pool per slot than the 24 GiB lanes.
run_gpu_parallel_tests: true
Expand All @@ -914,7 +917,7 @@ jobs:
run_cpu_only_tests: true
cpu_only_test_markers: sglang and gpu_0
# Exclude h100 tests: they need >24 GiB and run on the sglang-h100-test lane below.
gpu_test_markers: sglang and gpu_1 and not h100
gpu_test_markers: sglang and gpu_1 and not h100 and not sidecar
gpu_test_timeout_minutes: 240
# Profiled tests run in the VRAM-aware GPU stage; unprofiled fall through to sequential.
# Current single-GPU runners are 24 GiB, so this cap admits the profiled SGLang pool
Expand Down Expand Up @@ -986,7 +989,7 @@ jobs:
platform: '["amd64"]'
enable_coverage: true
run_sanity_check: false
gpu_test_markers: sglang and (gpu_1 or gpu_2)
gpu_test_markers: sglang and (gpu_1 or gpu_2) and not sidecar
gpu_test_timeout_minutes: 240
# 80 GiB H100 admits more of the profiled pool per slot than the 24 GiB lanes.
run_gpu_parallel_tests: true
Expand All @@ -1012,7 +1015,7 @@ jobs:
enable_coverage: true
run_cpu_only_tests: true
cpu_only_test_markers: trtllm and gpu_0
gpu_test_markers: trtllm and gpu_1
gpu_test_markers: trtllm and gpu_1 and not sidecar
gpu_test_timeout_minutes: 240
# Profiled tests run in the VRAM-aware GPU stage; unprofiled fall through to sequential.
# Current single-GPU runners are 24 GiB, so this cap admits the profiled TRT-LLM pool
Expand Down Expand Up @@ -1062,7 +1065,7 @@ jobs:
platform: '["amd64"]'
enable_coverage: true
run_sanity_check: false
gpu_test_markers: trtllm and (gpu_1 or gpu_2)
gpu_test_markers: trtllm and (gpu_1 or gpu_2) and not sidecar
gpu_test_timeout_minutes: 240
# 80 GiB H100 admits more of the profiled pool per slot than the 24 GiB lanes.
run_gpu_parallel_tests: true
Expand Down
27 changes: 24 additions & 3 deletions .github/workflows/post-merge-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ jobs:
extra_tags: |
${{ github.ref_name == 'main' && 'main-vllm-runtime' || '' }}
${{ github.ref_name == 'main' && format('main-vllm-runtime-{0}', github.sha) || '' }}
# Lets sidecar-vllm-test-image (pr.yaml) layer onto the latest main -test
# image instead of rebuilding vllm-runtime on every lib/sidecar/**-only PR.
test_extra_tags: |
${{ github.ref_name == 'main' && 'main-vllm-runtime-test' || '' }}
archive_sources: false
secrets: inherit

Expand Down Expand Up @@ -279,6 +283,10 @@ jobs:
extra_tags: |
${{ github.ref_name == 'main' && 'main-sglang-runtime' || '' }}
${{ github.ref_name == 'main' && format('main-sglang-runtime-{0}', github.sha) || '' }}
# Lets sidecar-sglang-test-image (pr.yaml) layer onto the latest main -test
# image instead of rebuilding sglang-runtime on every lib/sidecar/**-only PR.
test_extra_tags: |
${{ github.ref_name == 'main' && 'main-sglang-runtime-test' || '' }}
archive_sources: false
secrets: inherit

Expand Down Expand Up @@ -344,6 +352,10 @@ jobs:
extra_tags: |
${{ github.ref_name == 'main' && 'main-trtllm-runtime' || '' }}
${{ github.ref_name == 'main' && format('main-trtllm-runtime-{0}', github.sha) || '' }}
# Lets sidecar-trtllm-test-image (pr.yaml) layer onto the latest main -test
# image instead of rebuilding trtllm-runtime on every lib/sidecar/**-only PR.
test_extra_tags: |
${{ github.ref_name == 'main' && 'main-trtllm-runtime-test' || '' }}
archive_sources: false
secrets: inherit

Expand Down Expand Up @@ -452,7 +464,10 @@ jobs:
platform: '["amd64", "arm64"]' # arm64 for CPU tests, single GPU tests are skipped
run_cpu_only_tests: true
cpu_only_test_markers: '(pre_merge or post_merge) and vllm and gpu_0'
gpu_test_markers: '(pre_merge or post_merge) and vllm and gpu_1'
# not sidecar: sidecar-marked tests need dynamo-vllm-sidecar layered onto
# the image (see pr.yaml's sidecar-vllm-test), which this plain
# vllm-runtime image doesn't have.
gpu_test_markers: '(pre_merge or post_merge) and vllm and gpu_1 and not sidecar'
gpu_test_timeout_minutes: 120
# Profiled tests (those carrying @pytest.mark.profiled_vram_gib(N)) run concurrently in
# the parallel stage; the rest fall through to the sequential stage. 24 GiB admits all
Expand Down Expand Up @@ -550,7 +565,10 @@ jobs:
platform: '["amd64", "arm64"]' # arm64 for CPU tests, single GPU tests are skipped
run_cpu_only_tests: true
cpu_only_test_markers: '(pre_merge or post_merge) and sglang and gpu_0'
gpu_test_markers: '(pre_merge or post_merge) and sglang and gpu_1'
# not sidecar: sidecar-marked tests need dynamo-sglang-sidecar layered
# onto the image (see pr.yaml's sidecar-sglang-test), which this plain
# sglang-runtime image doesn't have.
gpu_test_markers: '(pre_merge or post_merge) and sglang and gpu_1 and not sidecar'
gpu_test_timeout_minutes: 120
# Profiled tests run in the VRAM-aware GPU stage; unprofiled fall through to sequential.
# Current single-GPU runners are 24 GiB, so this cap admits the profiled SGLang pool
Expand Down Expand Up @@ -590,7 +608,10 @@ jobs:
platform: '["amd64", "arm64"]' # arm64 for CPU tests, single GPU tests are skipped
run_cpu_only_tests: true
cpu_only_test_markers: '(pre_merge or post_merge) and trtllm and gpu_0'
gpu_test_markers: '(pre_merge or post_merge) and trtllm and gpu_1'
# not sidecar: sidecar-marked tests need dynamo-trtllm-sidecar layered
# onto the image (see pr.yaml's sidecar-trtllm-test), which this plain
# trtllm-runtime image doesn't have.
gpu_test_markers: '(pre_merge or post_merge) and trtllm and gpu_1 and not sidecar'
gpu_test_timeout_minutes: 120
# Profiled tests run in the VRAM-aware GPU stage; unprofiled fall through to sequential.
# Current single-GPU runners are 24 GiB, so this cap admits the profiled TRT-LLM pool
Expand Down
Loading
Loading