Repository navigation
fix(sglang): validate diffusion input_reference and bound media fetches #14435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmitry-tokarev-nv
merged 19 commits into
main
from
neelays/harden-diffusion-input-reference
Sep 16, 2026
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ec5be86
fix(sglang): validate diffusion input_reference against traversal and…
nnshah1 4db60f8
fix(sglang): extend input_reference validation to video diffusion; sh…
nnshah1 92201a2
fix(common-http): percent-decode file:// media paths (review)
nnshah1 5070d4c
fix(sglang): fetch diffusion input_reference URLs SSRF-safe (review)
nnshah1 f7e48c0
Merge remote-tracking branch 'origin/main' into pr14435-fix
dmitry-tokarev-nv 0debb20
fix(common-http): bound the media reference echoed into errors and logs
dmitry-tokarev-nv b716ec5
fix(common-http): let a caller cap how many bytes fetch_bytes will bu…
dmitry-tokarev-nv df50430
fix(common-http): make local_media_reference yield only a local path
dmitry-tokarev-nv 1d215cd
fix(sglang): return 400 for a rejected diffusion input_reference
dmitry-tokarev-nv 82aeb11
fix(common-http): bound the URL echoed by validate_url and the redire…
dmitry-tokarev-nv 02346fe
fix(common-http): close four gaps from a second review pass
dmitry-tokarev-nv dbf9e1d
fix(common-http): bound HttpStatusError where the binding actually re…
dmitry-tokarev-nv 4abc822
Merge remote-tracking branch 'origin/main' into pr14435-fix
dmitry-tokarev-nv 6ffa332
fix(common-http): stop the HttpStatusError bound eating actionable gu…
dmitry-tokarev-nv ec106be
Merge remote-tracking branch 'origin/main' into pr14435-fix
dmitry-tokarev-nv 1fad15c
Merge branch 'main' into pr14435-fix
dmitry-tokarev-nv 3f7e3db
fix(common-http): bound the OSError diagnostic and the data-URI media…
dmitry-tokarev-nv 3230408
fix(common-http): name aiohttp, not the removed backend, in two comments
dmitry-tokarev-nv 75c1a6d
feat(common-http): make the media download cap operator-tunable
dmitry-tokarev-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.