chore: install datagen in vllm image and CI

[PeaBrane]

Overview:

Addresses failing CI tests in #1087 and also make datagen on dynamo installation

Summary by CodeRabbit

• Chores
  • Updated workflow and Dockerfile to streamline the installation process of the benchmarks package during testing and CI, improving efficiency without affecting user-facing features.

[coderabbitai]

Walkthrough

The changes move the installation of the benchmarks package from the GitHub Actions workflow into the Dockerfile. The Dockerfile installs the benchmarks package from the /workspace/benchmarks directory using pip install, while the workflow no longer installs the package before running pytest.

Changes

File(s)	Change Summary
.github/workflows/pre-merge-python.yml	Removed explicit pip install -e /workspace/benchmarks before running pytest in the workflow.
container/Dockerfile.vllm	Added pip install /workspace/benchmarks command in the ci_minimum stage to install benchmarks.

Poem

The Docker now installs with care,
Benchmarks in place, no need to prepare.
Workflows are lean, the steps are few,
Pytest runs smoothly, as rabbits hop through.
In containers we trust, for builds fast and true! 🐇

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22e34ef and 0111dd1.

📒 Files selected for processing (1)

• container/Dockerfile.vllm (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• container/Dockerfile.vllm

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Mirror Repository to GitLab
• GitHub Check: Build and Test - vllm

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9281c95 and f7e932e.

📒 Files selected for processing (2)

• .github/workflows/pre-merge-python.yml (1 hunks)
• container/Dockerfile.vllm (2 hunks)

🧰 Additional context used

🪛 GitHub Actions: NVIDIA Test Github Validation

container/Dockerfile.vllm

[error] 239-241: Failed to build 'data-generator' package during 'uv pip install -e .' in /tmp/benchmarks: error: could not create 'data_generator.egg-info': Read-only file system. This indicates a problem with the package or the build environment.

🔇 Additional comments (2)

container/Dockerfile.vllm (1)

450-452: Reinstall benchmarks for CI consistency
Reinstalling under ci_minimum after COPY . /workspace is correct to pick up source changes. Consider merging this step with other RUN commands to reduce layers, but the logic is sound.

.github/workflows/pre-merge-python.yml (1)

57-57:

❓ Verification inconclusive

Validate Benchmarks Package Installation
You’ve removed the runtime pip install -e /workspace/benchmarks, which aligns with Dockerfile changes. Ensure the ci_minimum image indeed includes the editable benchmarks install so pytest can import it.
Generate and run this script to confirm:

---

🏁 Script executed:

#!/bin/bash
# Verify benchmarks is installed in the CI image
IMAGE_TAG=dynamo:latest-vllm
docker run --rm $IMAGE_TAG bash -c "uv pip show benchmarks"

Length of output: 197

---

Validate Benchmarks Package Availability in CI Image
Since we’ve removed the pip install -e /workspace/benchmarks step to match the Dockerfile updates, please confirm that the ci_minimum image already provides the editable benchmarks package so pytest can import it. You can verify this locally by running:

docker run --rm <your-image-tag> bash -c "pip show benchmarks"

Replace <your-image-tag> with steps.define_image_tag.outputs.image_tag. If pip show benchmarks does not list the package, update your base image or re-add the install step.

[PeaBrane]

@coderabbitai full review