Repository navigation
chore: update dynamo-protocols to 5.4.1 - #14154
Conversation
Picks up ai-dynamo/frontend-crates#202 (frontend-crates#157): chat completion responses omit absent optional fields instead of emitting null, and always carry the spec-required refusal field. Pure pin bump; no Dynamo source changes. Root Cargo.toml pin =5.4.0 -> =5.4.1; Cargo.lock, lib/bindings/python/Cargo.lock and lib/bindings/kvbm/Cargo.lock each move exactly one package. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: doxu <doxu@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe workspace updates the exact ChangesProtocol dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR updates the pinned dependency and matching lockfiles without source-code changes or identified behavioral correctness risks. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The dependency update addresses the linked issue's optional-field serialization goal, but the description states that message.refusal is always emitted as null when absent. Direct issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Description checkExplanation The description includes all required sections, explains the dependency and lockfile changes, identifies the reviewer starting point, and links the related issues. It also states the scope and compatibility impact clearly.
Comment |
|
/ok to test 5dab00c |
Signed-off-by: doxu <doxu@nvidia.com>
Overview:
Bumps the pinned
dynamo-protocolsdependency from 5.4.0 to 5.4.1, which picks up ai-dynamo/frontend-crates#202 (closes ai-dynamo/frontend-crates#157). That release aligns/v1/chat/completionsresponse serialization with the OpenAI spec: optional fields are omitted when absent instead of being emitted as explicitnull, and the required-and-nullablerefusalfield is always present.Wire changes visible to clients after this bump:
usage/service_tier/system_fingerprint(non-stream + stream)nullwhen absentid/type/function.nameon continuation chunksnullmessage.reasoning_content(Dynamo extension)nullwhen absentusage.prompt_tokens_details.audio_tokensetc.nullwhen absentmessage.refusalnullwhen no refusal), matching OpenAIfinish_reason, non-streamlogprobs,message.contentDeserialization is unaffected in both directions: payloads with or without the keys decode identically, so mixed-version frontend/worker deployments are safe. Official OpenAI SDKs (pydantic/zod models) are unaffected; only raw dict indexing such as
chunk["usage"]on intermediate stream chunks would observe the change — and that code already fails against api.openai.com, which never emits those keys.Details:
Root
Cargo.tomlmoves the pin from=5.4.0to=5.4.1. That is the only pin site in the tree;lib/llm/Cargo.tomlandlib/backend-common/Cargo.tomlinherit it viaworkspace = true.The three lockfiles are refreshed to match:
Cargo.lock,lib/bindings/kvbm/Cargo.lock, andlib/bindings/python/Cargo.lock(the two bindings crates are separate workspaces with their own lockfiles). Each moves exactly one package,dynamo-protocols 5.4.0 -> 5.4.1; no other dependency changes.No Dynamo source changes: 5.4.1 keeps every public type identity (
CompletionUsageetc. remain upstream re-exports), so this is a pure pin bump.Where should the reviewer start?
Cargo.tomlline 71. Everything else is lockfile churn fromcargo update -p dynamo-protocols --precise 5.4.1.Related Issues
🔗 This PR is linked to an issue:
Summary by CodeRabbit