Repository navigation
build: pin dynamo-llm version in backend-common for cargo publish (1.4.1) - #13670
Merged
pvijayakrish merged 1 commit intoAug 22, 2026
Merged
pvijayakrish merged 1 commit into
pvijayakrish merged 1 commit into
Conversation
…4.1) Cherry-pick of 7fa9245 + 907976f onto release/1.4.1, with the pin stamped to this branch's version. cargo publish rejects backend-common because its dynamo-llm dependency is a path dep with no version requirement ("all dependencies must have a version requirement specified when publishing" — seen live in the 1.4.1 crates publish; 17 of the 18 crates published, this one cannot). It is a direct path dep because cargo cannot express `workspace = true` together with `default-features = false`; pin the version inline (1.4.1, equal to [workspace.package].version) and teach apply_dev_version.py to stamp such inline pins so future version bumps keep it in sync. Signed-off-by: pvijayakrish <pvijayakrish@nvidia.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
dagil-nvidia
approved these changes
Aug 22, 2026
pvijayakrish
deleted the
pvijayakrish/backend-common-publish-version-1.4.1
branch
August 22, 2026 03:56
Contributor
Author
|
Checks failing are verified to be unrelated and artifactory infra flakiness. |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of 7fa9245 + 907976f onto release/1.4.1, with the pin stamped to this branch's version.
cargo publish rejects backend-common because its dynamo-llm dependency is a path dep with no version requirement ("all dependencies must have a version requirement specified when publishing" — seen live in the 1.4.1 crates publish; 17 of the 18 crates published, this one cannot). It is a direct path dep because cargo cannot express
workspace = truetogether withdefault-features = false; pin the version inline (1.4.1, equal to [workspace.package].version) and teach apply_dev_version.py to stamp such inline pins so future version bumps keep it in sync.