Skip to content

fix(operator): tolerate transient worker liveness failures #13512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmonty12 merged 8 commits into from
Sep 8, 2026
Merged

fix(operator): tolerate transient worker liveness failures #13512

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cdec429
fix(operator): tolerate transient worker liveness failures
xianlubird Aug 19, 2026
204da9b
test(operator): update worker liveness threshold expectation
xianlubird Aug 19, 2026
5300595
Merge origin/main into codex/fix-worker-liveness-threshold
xianlubird Aug 31, 2026
b5d080c
Merge origin/main into codex/fix-worker-liveness-threshold
xianlubird Sep 2, 2026
74d4860
docs(operator): fix worker liveness timeout
xianlubird Sep 2, 2026
e3dcb10
Merge origin/main into codex/fix-worker-liveness-threshold
xianlubird Sep 2, 2026
f1ea32f
Merge branch 'main' into codex/fix-worker-liveness-threshold
xianlubird Sep 3, 2026
f60f26b
chore(operator): merge main and adapt liveness test to current pod API
xianlubird Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/operator/internal/dynamo/component_worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func (w *WorkerDefaults) GetBaseContainer(context ComponentContext) (corev1.Cont
},
PeriodSeconds: 5,
TimeoutSeconds: 4, // TimeoutSeconds should be < PeriodSeconds
FailureThreshold: 1, // Note this default FailureThreshold is 3, with 1 a single failure will restart Pod
FailureThreshold: 3,
Comment thread
xianlubird marked this conversation as resolved.
Outdated
}

// ReadinessProbe in Dynamo worker context doesn't determine that the worker is ready to receive traffic
Expand Down
4 changes: 2 additions & 2 deletions deploy/operator/internal/dynamo/graph_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2220,7 +2220,7 @@ func TestGenerateGrovePodCliqueSet(t *testing.T) {
TimeoutSeconds: 4,
PeriodSeconds: 5,
SuccessThreshold: 0,
FailureThreshold: 1,
FailureThreshold: 3,
},
ReadinessProbe: &corev1.Probe{
ProbeHandler: corev1.ProbeHandler{
Expand Down Expand Up @@ -5676,7 +5676,7 @@ func TestGenerateBasePodSpec_Worker(t *testing.T) {
},
PeriodSeconds: 5,
TimeoutSeconds: 4,
FailureThreshold: 1,
FailureThreshold: 3,
},
ReadinessProbe: &corev1.Probe{
ProbeHandler: corev1.ProbeHandler{
Expand Down
Loading