feat(vllm): add Prime RL protocol parity - #13377
Open
biswapanda wants to merge 1 commit into
Open
Conversation
Signed-off-by: Biswa Panda <biswa.panda@gmail.com>
biswapanda
temporarily deployed
to
external_collaborator
August 17, 2026 18:10 — with
GitHub Actions
Inactive
biswapanda
temporarily deployed
to
external_collaborator
August 17, 2026 18:10 — with
GitHub Actions
Inactive
Contributor
|
/ok to test b197fd5 |
Contributor
|
👋 Hi biswapanda! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
This comment has been minimized.
This comment has been minimized.
biswapanda
marked this pull request as ready for review
August 17, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Add the remaining generic Dynamo contracts needed for Prime-RL to train against independently deployed vLLM-RS workers through the native sidecar path. This is intentionally a stacked draft on #13066 so the review contains only the Prime-RL integration and protocol-parity delta.
Details:
/collective_rpc; this is a development compatibility endpoint, not the intended production control APIStack
feat/vllm-sidecar-rlatacc5ee96e39c4c84506f87aa2fd15589682deb4e, the exact feat(vllm): route RL controls through sidecar #13066 head used for end-to-end validation.Validation
cargo fmt --all -- --checkcargo test -p dynamo-vllm-sidecar(33 unit tests plus the executable doctest)cargo test -p dynamo-llm protocols::openai::generate(28 tests)cargo test -p dynamo-kv-router mm_identifier_hash_preserves_vllm_and_opaque_identifiersQwen/Qwen3-VL-4B-Instructmultimodal training and post-update generationWhere should the reviewer start?
lib/backend-common/src/rl.rsfor the RL route and request contractslib/llm/src/http/service/generate.rsandlib/llm/src/protocols/openai/generate.rsfor canonical routing, typed multimodal data, and routed-experts accumulationlib/sidecar/vllm/proto/inference.protoandlib/sidecar/vllm/src/convert.rsfor the generic vLLM-RS wire and lowering boundarylib/sidecar/vllm/src/tests.rsfor the protocol and execution-identity contractsRelated Issues
This PR is NOT linked to an issue: