build: use published Aiconfigurator 0.11.0 - #13280
Conversation
Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
|
||
| mocker = [ | ||
| "aiconfigurator-core @ git+https://github.com/ai-dynamo/aiconfigurator.git@614b9c8c8725332533616786e2eb049df48935f0#subdirectory=aic-core", | ||
| "aiconfigurator-core==0.11.0", |
There was a problem hiding this comment.
🔍 AIC consistency guard is still skipped with a now-stale reason
The dependency consistency test that enforces "every AIC dependency pins one published release" is unconditionally skipped with the reason "release/1.4.0 pins AIC to an immutable Git source" (tests/dependencies/test_aiconfigurator_consistency.py:22-29). That reason no longer holds after this PR: the helpers in that file specifically assert index-resolvable Python requirements (_python_exact_version rejects URLs) and crates.io-sourced Cargo entries with a registry checksum (_cargo_lock_version), which is exactly the state the diff establishes. Removing the skip would give automated protection against future drift between the two Cargo manifests, the two Cargo.lock files, and the five Python requirement declarations touched here.
Was this helpful? React with 👍 or 👎 to provide feedback.
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
|
🎯 Code Coverage (details) 🔗 Commit SHA: 853805e | Docs | Datadog PR Page | Give us feedback! |
…rence, recipe ID fix Fix the helm-docs source template's docs link (the generated README was fixed but generate-helm-docs regenerated the old link, dirtying the operator check). Adopt main's refreshed vLLM benchmark sampling-flag reference (#13036 — same shipped flag set, code-verified prose) and the Qwen3.8 recipe model-ID correction (#13265). Triaged all main docs commits since the last snapshot point: #13192 and #11723 docs excluded (features absent from 1.4.0); release-side #13280/#13256 have no docs impact (AIC-core wheel is a Spica dependency; planner shim wording verified still correct). Signed-off-by: Dan Gil <dagil@nvidia.com>
2 participants
Summary
aiconfigurator==0.11.0andaiconfigurator-core==0.11.0releases[patch.crates-io]overrides and refresh both Cargo lockfiles to the crates.io source and checksumallow-direct-referencesopt-in now that the Python metadata no longer contains direct referencesValidation
cargo tree --locked -p dynamo-mocker --features aic-forward-pass -i aiconfigurator-corecargo tree --locked --manifest-path lib/bindings/python/Cargo.toml --features aic-forward-pass -i aiconfigurator-coregit diff --check