Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 12, 2026 08:35
b84931d to
e2378a7
Compare
Contributor
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 12, 2026 21:16
010f43e to
2484ecd
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 12, 2026 21:17
3fdc640 to
06196c1
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 12, 2026 21:58
2484ecd to
4f42576
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 12, 2026 21:58
06196c1 to
d97c40e
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 12, 2026 22:32
4f42576 to
fbd3a07
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 12, 2026 22:32
d97c40e to
3c40733
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 13, 2026 00:20
a8a7079 to
b9e3f60
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 13, 2026 00:20
3c40733 to
7f8547f
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 13, 2026 22:14
b9e3f60 to
fb6d0fd
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 13, 2026 22:22
7f8547f to
8de19c5
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 13, 2026 23:14
fb6d0fd to
b199fcb
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 13, 2026 23:15
8de19c5 to
97c5cd9
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 13, 2026 23:32
b199fcb to
5d2b429
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 13, 2026 23:33
97c5cd9 to
2b18280
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 14, 2026 05:15
5d2b429 to
bba4aa7
Compare
furionw
changed the base branch from
qiwa/workflow-remote-execution
to
qiwa/workflow-nixl-carrier
August 14, 2026 05:15
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 14, 2026 05:15
2b18280 to
d9d4c5d
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
2 times, most recently
from
August 20, 2026 08:05
3776575 to
43cb87d
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 21, 2026 04:44
8e2760d to
ad7133d
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 21, 2026 04:44
43cb87d to
ae34ef9
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 21, 2026 04:54
ad7133d to
49e2f9a
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 21, 2026 04:54
ae34ef9 to
00fb3d7
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 22, 2026 00:04
49e2f9a to
b0a2417
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 22, 2026 00:29
00fb3d7 to
0e71f3f
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 22, 2026 00:46
b0a2417 to
4b5260c
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 22, 2026 00:46
0e71f3f to
7fba583
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 23, 2026 18:22
4b5260c to
22ba645
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 23, 2026 18:24
7fba583 to
15effa9
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 23, 2026 18:26
fb84356 to
b5b16ad
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 23, 2026 18:26
15effa9 to
eb6d649
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 23, 2026 18:30
b5b16ad to
b54e963
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
2 times, most recently
from
August 23, 2026 21:38
2234f2c to
accdc07
Compare
furionw
force-pushed
the
qiwa/workflow-remote-execution
branch
from
August 25, 2026 21:26
d6fb423 to
50c0c67
Compare
furionw
force-pushed
the
qiwa/workflow-frontend-provider
branch
from
August 25, 2026 21:27
accdc07 to
a75493d
Compare
furionw
marked this pull request as ready for review
August 25, 2026 23:10
| WorkflowEndpointHandler(orchestrator) | ||
|
|
||
|
|
||
| async def test_endpoint_handler_cancels_workflow_when_context_stops() -> None: |
Contributor
There was a problem hiding this comment.
🟡 Cancellation test can hang CI forever without a timeout
This test drives BlockingRunner, which awaits asyncio.Event().wait() and only unblocks when the handler cancels the workflow. It carries no @pytest.mark.timeout. If the cancellation path regresses, the async-for never completes and the run hangs indefinitely. The pytest guidelines require a timeout on any test with an unbounded wait.
Suggested change
| async def test_endpoint_handler_cancels_workflow_when_context_stops() -> None: | |
| @pytest.mark.timeout(30) | |
| async def test_endpoint_handler_cancels_workflow_when_context_stops() -> None: |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #13081.
Why
The generic frontend should remain independent of workflow authoring and deployment. A workflow orchestrator running as an ordinary discovered model worker still needs a small boundary between Dynamo's endpoint generator ABI and the orchestrator's unary request/chunk contract.
What Change
WorkflowEndpointHandlerfor bound orchestrators.WorkflowIR.classDiagram WorkflowEndpointHandler --> WorkflowOrchestrator : executes request/chunk ABI WorkflowOrchestrator --> WorkflowIR : exposes logical endpoint contract WorkflowOrchestrator --> GraphScheduler : schedules bound graph WorkflowEndpointHandler ..> Endpoint : served by worker note for WorkflowEndpointHandler "Adapts discovered endpoint requests" note for WorkflowOrchestrator "Owns one bound workflow"Test Plan