-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(vllm): migrate GLM-Image NIXL config to the stages deploy schema (cherry-pick #12984) #13033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pvijayakrish
merged 1 commit into
release/1.4.0
from
gluo/cherrypick-12984-glm-image-nixl-stages-schema
Aug 11, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 oc.decode on AR_TP relies on lazy interpolation when AR_TP is unset (DiT node)
tensor_parallel_sizenow goes through${oc.decode:...}. OmegaConf'soc.decoderaisesTypeErrorwhen handed a non-string (the unquoted literal1in an interpolation default is parsed as an int, not a string), so this expression only survives if either the env var is set or the value is never resolved. On the DiT node,examples/backends/vllm/launch/disagg_omni_glm_image_nixl.shdoes not exportAR_TP, so stage 0's field would resolve to the int default if the loader eagerly resolves the whole file. The identical pattern already existed fornum_gpus: ${oc.decode:${oc.env:DIT_TP,1}}on the AR node before this PR (and the author reports a successful 2-GPU run), which is the reason this is not flagged as a bug — but a cross-node run whereAR_TPis unset on the DiT machine is worth an explicit check, and quoting the defaults (${oc.env:AR_TP,'1'}) would make it unconditionally safe.Was this helpful? React with 👍 or 👎 to provide feedback.