Skip to content

fix(ci): gate fern-check job on docs OR fern_components - #13001

Closed
weizhoublue wants to merge 1 commit into
ai-dynamo:mainfrom
weizhoublue:fix/pr-12388-051033-4177876
Closed

fix(ci): gate fern-check job on docs OR fern_components#13001
weizhoublue wants to merge 1 commit into
ai-dynamo:mainfrom
weizhoublue:fix/pr-12388-051033-4177876

Conversation

@weizhoublue

@weizhoublue weizhoublue commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Overview:

fix(ci): gate fern-check job on docs OR fern_components so self-editing workflow changes self-verify

Details:

Where should the reviewer start?

.github/filters.yaml:30 lists .github/workflows/pre-merge.yml under fern_components.

In pre-merge.yml, the step Parse custom MDX components declares this dependency:

if: needs.changed-files.outputs.fern_components == 'true'

Therefore, in pre-merge.yml, the job fern-check that contains it must ensure:

if: needs.changed-files.outputs.docs == 'true' || needs.changed-files.outputs.fern_components == 'true

Related Issues

⚠️ This section is required. Choose one path below and delete the other.

🔗 This PR is linked to an issue:

  • Closes #XXXX

🚫 This PR is NOT linked to an issue:

  • Confirmed — no related issue

@copy-pr-bot

copy-pr-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@weizhoublue
weizhoublue temporarily deployed to external_collaborator August 11, 2026 05:35 — with GitHub Actions Inactive
@weizhoublue
weizhoublue temporarily deployed to external_collaborator August 11, 2026 05:35 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi weizhoublue! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions Bot added external-contribution Pull request is from an external contributor actions fix labels Aug 11, 2026
…ng workflow changes self-verify

Signed-off-by: weizhoublue <weizhou.lan@daocloud.io>
@weizhoublue
weizhoublue force-pushed the fix/pr-12388-051033-4177876 branch from 4f907a6 to ab4a46f Compare August 11, 2026 05:37
@weizhoublue
weizhoublue temporarily deployed to external_collaborator August 11, 2026 05:37 — with GitHub Actions Inactive
@weizhoublue

Copy link
Copy Markdown
Contributor Author

@dagil-nvidia
Hi, please help check whether this follow-up PR for #12388 makes sense, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions external-contribution Pull request is from an external contributor fix size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant