fix(docs): regenerate the release tables stranded by #12110 - #12985
Merged
dagil-nvidia merged 2 commits intoAug 11, 2026
Conversation
main fails the gen-llms-tables-check pre-commit hook, so every open PR fails it too regardless of content -- #12977 touches only .github/codeowners and still went red on it. Cause is a merge-order gap between two of my own PRs. #12529 landed the hook with its outputs current. #12110 then changed the source, components/releases.data.ts, correcting the dynamo-config crate link from 1.3.0 to 1.2.1 because crates.io was never republished for 1.3.0 -- but did not regenerate the artifacts built from it. #12110 predated the hook, so nothing on that branch caught it, and the staleness only became visible once both were on main. Regenerating propagates that same correction into releases.json, releases-machine-readable.mdx and release-artifacts.mdx, which still advertise 'cargo add dynamo-config@1.3.0' -- a command that resolves to a version crates.io does not have. So this is not only a green-CI fix; the published docs currently tell readers to install something that does not exist. No hand edits: the three files are the generator's output, unmodified. Validation: gen_llms_tables.py --check exits 0 after regeneration, and exits 1 on main before it. Signed-off-by: Dan Gil <dagil@nvidia.com>
github-actions
Bot
added
fix
documentation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
WalkthroughThe release metadata and documentation update ChangesRelease artifact version alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
dagil-nvidia
enabled auto-merge (squash)
August 11, 2026 00:35
Second stale generator on main, same class as the release tables in the previous commit and blocking every PR the same way: gen_python_api.py --check fails on pristine origin/main, so any PR that runs pre-merge inherits it. Cause is #12820 (fix(frontend): return SGLang chat logprobs), which moved code in components/src/dynamo/frontend/. The reference deep-links to exact source lines, so shifting sglang_processor.py and sglang_prepost.py by ~54 and ~104 lines invalidated eight of them. Nothing about the docstrings changed; the line anchors did. That is worth noting for anyone editing that package: this reference goes stale on any line-number shift in the source it documents, not only on docstring edits. #12820 had no way to know -- the generator landed with #12110 after it was already open. Output only, no hand edits. Validation: all four generators (--check on python, rust, kubernetes, plus gen_llms_tables) now pass on this branch; python and llms_tables both fail on pristine main. Signed-off-by: Dan Gil <dagil@nvidia.com>
Collaborator
Author
|
/ok to test 8853852 |
Contributor
dagil-nvidia
requested review from
PeaBrane,
akshatha-k,
athreesh,
harryskim,
nealvaidya and
tedzhouhk
August 11, 2026 01:05
PeaBrane
approved these changes
Aug 11, 2026
dagil-nvidia
added a commit
that referenced
this pull request
Aug 11, 2026
Clean auto-merge. Picks up #12985, which unbroke the two stale generated artifacts on main -- this PR was failing pre-commit on those, not on anything it changes. Validation: 88 tests pass; CODEOWNERS regenerates byte-identical to main, so the advisory removal still changes no routing. Signed-off-by: Dan Gil <dagil@nvidia.com>
dagil-nvidia
added a commit
that referenced
this pull request
Aug 11, 2026
Clean auto-merge. Picks up #12985, which unbroke the two stale generated artifacts on main -- this PR was failing pre-commit on those rather than on its own content. Validation: docs_lint --scan docs exits 0; the aggregator needs list still resolves all 11 entries to defined jobs. Signed-off-by: Dan Gil <dagil@nvidia.com>
athreesh
approved these changes
Aug 11, 2026
This was referenced Aug 11, 2026
dagil-nvidia
added a commit
that referenced
this pull request
Aug 12, 2026
…elf-heal Two gaps found pressure-testing this, both of which matter more now that the publish gate is staying blocking rather than being relaxed. Blast radius. The happy path pushes to main unreviewed, so an unbounded diff is the one way this job can do real damage: a merge that moves a documented symbol touches a handful of pages, but a BROKEN generator rewrites all of them. Real regenerations for scale -- #12985 was 4 files, #13035 was 6 -- so the cap is 20 files or 2000 lines. Over that, the direct push is skipped entirely and the change goes to a branch for review. Silent failure. The job previously exited 0 after falling back to a branch. With the gate blocking, a fallback is not a nuisance, it is a publish outage: main carries stale references and docs.nvidia.com will not update until someone opens that PR. A green run hides exactly that, which is how update-events.yml failed 100 times without anyone noticing. The job now fails on the fallback path and routes through notify-slack.yml, the same notifier nightly and post-merge already use. Deliberate asymmetry: pushing to main is a success, falling back is a failure. Both leave the tree correct; only one leaves the publish blocked. Validation: YAML parses, both jobs resolve, every run: block passes bash -n. Signed-off-by: Dan Gil <dagil@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maincurrently fails thegen-llms-tables-checkpre-commit hook, so every open PR fails itregardless of content — #12977 touches only
.github/codeowners/and still went red on it.The cause is a merge-order gap between two of my own PRs:
components/releases.data.ts— correcting thedynamo-configcrate link from1.3.0to1.2.1, because crates.io was never republished for1.3.0 — without regenerating the artifacts built from it.
#12110 predated the hook, so nothing on that branch caught it. The staleness only became visible
once both were on
main.This is not only a CI fix
Regenerating propagates that same correction into
releases.json,releases-machine-readable.mdx, andrelease-artifacts.mdx, which still advertise:That command resolves to a version crates.io does not have. The published docs currently tell
readers to install something that does not exist.
Changes
Three files, all generator output, no hand edits:
docs/fern/assets/releases.jsondocs/fern/pages/reference/general/releases-machine-readable.mdxdocs/fern/pages/reference/general/release-artifacts.mdxValidation
gen_llms_tables.py --checkexits 1 onmainbefore this change and 0 after.1.3.0→1.2.1propagation; nothing else moves.🤖 Generated with Claude Code
Summary by CodeRabbit
dynamo-configrelease artifact version from1.3.0to1.2.1across release metadata and reference documentation.