feat(self-host): default self-hosted metadata to on (cherry-pick #11417) - #12963
Merged
pvijayakrish merged 1 commit intoAug 11, 2026
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+214
to
215
| /// Opt in or out of self-hosting MDC artifacts. Default `true`. | ||
| pub fn self_host_metadata(&mut self, enabled: bool) -> &mut Self { |
Contributor
There was a problem hiding this comment.
🔍 Python binding default still defers to env, so default flips there too
lib/bindings/python/rust/lib.rs:625-626 only calls builder.self_host_metadata(...) when the Python caller passes an explicit value, so all Python-side registrations inherit the new default-on behavior via LocalModelBuilder::default(). That is consistent with the intent, but it means every Python worker without DYN_SYSTEM_PORT set now takes the fallback branch and emits the new warning — worth confirming deployment manifests set DYN_SYSTEM_PORT for the release branch.
Was this helpful? React with 👍 or 👎 to provide feedback.
![dynamo-review-agent[bot]](https://avatars.githubusercontent.com/u/201626793?s=60&v=4){kind=small}
|
🎯 Code Coverage (details) 🔗 Commit SHA: 199e95a | Docs | Datadog PR Page | Give us feedback! |
pvijayakrish
deleted the
tmonty12/cp-11417-self-host-metadata-default-release-1.4.0
branch
August 11, 2026 00:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release/1.4.0.DYN_SELF_HOST_METADATAis unset; explicit falsy values (0,false,no, oroff) continue to opt out.Why
On
release/1.4.0, self-hosted metadata is opt-in. When it is disabled, workers publish localfile://metadata paths, so a newly rolled frontend can fall back to its own--model-pathand reject an older worker'sconfig.jsonwhen their checksums differ. Defaulting self-hosting on lets the frontend fetch and verify metadata from each worker generation instead.Original PR
a96587663c5d9d46636871d868d7529b22d647b4199e95a8c0Validation
git cherry-pick -x -s a96587663c5d9d46636871d868d7529b22d647b4applied cleanly.git diff --check origin/release/1.4.0...HEADpassed.