docs(contributing): clarify verified CI requirement - #12763
docs(contributing): clarify verified CI requirement#12763kristinapathak wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
WalkthroughThe documentation updates define GitHub-verified signatures on every fork pull request commit as a prerequisite for automatic trusted-CI approval. The PR monitor guidance adds verification commands, summary text, and remediation instructions for unverified commits. ChangesFork CI verification
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Comment |
|
🔄 Datadog auto-retried 1 job - 1 passed on retry 🔗 Commit SHA: 673bd09 | Docs | Datadog PR Page | Give us feedback! |
c147828 to
0281aae
Compare
|
/ok to test 0281aae |
|
/ok to test c65121f |
harryskim
left a comment
There was a problem hiding this comment.
Approving — the added prose is accurate against .github/workflows/trigger-ci-approval-flow.yml, and the pages/reference/api/python/* churn is expected generator output.
Non-blocking follow-ups, happy for these to land separately:
- The English side got this in one place (
dco-and-licensing.md) while the zh-CN overview got it in two. The English counterparts of both zh-CN spots are untouched:getting-started.mdx(Configure DCO sign-offstep) andcontribution-flow.mdx(Complete automated review and CIstep).getting-started.mdxis the setup page contributors are routed to, so it's the highest-value place for the note. /ok to testappears nowhere else indocs/fern/pages, so the new section references an undefined term for English readers. The zh-CN overview defines it, which is why it reads fine there.- Two things the workflow does that the docs don't say: signing alone isn't sufficient (a contributor not in
APPROVED_EXTERNAL_CONTRIBUTORSnever gets automatic approval regardless of signatures), and a maintainer can still post/ok to test <sha>manually — the bot's own comment tells contributors they don't need to rewrite commits for that path. Without #3, expect "I signed everything, why no CI?" reports and unnecessary branch-wide re-signing.
Minor: the new section splits the page's Create -> Verify -> Repair spine ("Repair the Latest Commit" now reads as if it repairs the signing problem); Verified is bold in CONTRIBUTING.md but backticked elsewhere; and the Devin comment about the DCO page not being updated is stale.
c65121f to
1b13726
Compare
Signed-off-by: Kristina Pathak <kristina.m.pathak@gmail.com>
Signed-off-by: Kristina Pathak <kristina.m.pathak@gmail.com>
Signed-off-by: Kristina Pathak <kristina.m.pathak@gmail.com>
1b13726 to
673bd09
Compare
|
/ok to test 19cd52f |
Summary
pr-monitortroubleshooting.Validation
git diff --checkuv run --no-project --with PyYAML python3 scripts/validate_skills.pySummary by CodeRabbit