Skip to content

fix(vllm): declare entry-stage engine_input_source in GLM-Image NIXL config (cherry-pick #12709) #12719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvijayakrish merged 1 commit into from
Aug 5, 2026
Merged

fix(vllm): declare entry-stage engine_input_source in GLM-Image NIXL config (cherry-pick #12709) #12719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/backends/vllm/launch/stage_configs/glm_image_nixl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ stage_args:
distributed_executor_backend: "mp"
enable_prefix_caching: false
max_num_batched_tokens: 32768
# Entry stage: input comes from the request, not from another stage.
# Declared explicitly because the stage_args format applies no schema
# defaults, and vLLM-Omni reads this field unconditionally.
engine_input_source: []

@devin-ai-integration devin-ai-integration Bot Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Fix may only clear the first startup failure

The PR description itself notes that DYN-3746 argues this config needs a broader migration (stage_args → stages, nested engine_args:/runtime: forms, and a different connector declaration form) and that end-to-end validation on two H100s has not been performed. If that analysis still holds, the AR stage may fail at a later init step for a different missing key; a follow-up run of disagg_omni_glm_image_nixl.sh on the 1.4.0 image is warranted before assuming the pipeline reaches ready.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

# Explicit connector mapping for AR -> DiT
output_connectors:
to_stage_1: ar_to_dit_nixl
Expand Down
Loading